Skip to content
Snippets Groups Projects

Add extra information to state change notes

What does this MR do and why?

This MR updates merged state change note when related MRs get marked as merged when its diff_head_sha is included in another MR which just got merged. Users are getting confused as we currently just say merged regardless of why we mark them as merged. Only the MRs that get merged via GitLab UI should have a note that just say merged after this change.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

When merging of another MR via GitLab UI triggered the merge:

Screenshot_2024-03-28_at_7.20.55_PM

When merging manually outside of GitLab UI triggered merge:

Screenshot_2024-03-28_at_7.20.19_PM

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Related to #436061 (closed)

Edited by Sincheol (David) Kim

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • requested review from @kerrizor

  • requested review from @dgruzd

  • requested review from @aqualls

  • Dmitry Gruzd approved this merge request

    approved this merge request

  • Dmitry Gruzd requested review from @DylanGriffith and removed review request for @dgruzd

    requested review from @DylanGriffith and removed review request for @dgruzd

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for f4e2f86f

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Data Stores | 31     | 0      | 0       | 0     | 31    | ✅     |
    | Create      | 83     | 0      | 9       | 0     | 92    | ✅     |
    | Govern      | 56     | 0      | 10      | 0     | 66    | ✅     |
    | Plan        | 51     | 0      | 2       | 0     | 53    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Package     | 24     | 0      | 6       | 0     | 30    | ✅     |
    | Verify      | 35     | 0      | 1       | 0     | 36    | ✅     |
    | Monitor     | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 294    | 0      | 29      | 0     | 323   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :white_check_mark: test report for f4e2f86f

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 570    | 0      | 66      | 10    | 636   | ✅     |
    | Package     | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Govern      | 6      | 0      | 0       | 0     | 6     | ✅     |
    | Plan        | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Data Stores | 4      | 0      | 0       | 0     | 4     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 596    | 0      | 68      | 10    | 664   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Amy Qualls approved this merge request

    approved this merge request

  • Amy Qualls added tw-weight3 twfinished labels and removed twtriaged label

    added tw-weight3 twfinished labels and removed twtriaged label

  • Amy Qualls removed review request for @aqualls

    removed review request for @aqualls

  • Kerri Miller approved this merge request

    approved this merge request

  • requested review from @lma-git

  • mentioned in issue #455485

  • Dylan Griffith approved this merge request

    approved this merge request

  • added databaseapproved label and removed databasereviewed label

  • Dylan Griffith removed review request for @DylanGriffith

    removed review request for @DylanGriffith

  • Leaminn Ma approved this merge request

    approved this merge request

  • Leaminn Ma resolved all threads

    resolved all threads

  • Leaminn Ma enabled an automatic merge when the pipeline for 38a6697a succeeds

    enabled an automatic merge when the pipeline for 38a6697a succeeds

  • merged

  • Hello @dskim_gitlab :wave:

    The database team is looking for ways to improve the database review process and we would love your help!

    If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:

    @gitlab-org/database-team

    And someone will be by shortly!

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • Leaminn Ma mentioned in commit 95a5e7dc

    mentioned in commit 95a5e7dc

  • added workflowstaging label and removed workflowcanary label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading