Skip to content

Resolve "Lead time chart does not work in dark mode"

Chad Lavimoniere requested to merge 452256-lead-time-chart-does-not-work-in-dark-mode into master

What does this MR do and why?

The dark mode issue with the lead time for changes chart was caused by using a canvas renderer, which was a workaround meant to avoid a bug in version 4.x of echarts. We now use version 5+ of echarts, so we don't need the workaround, and it can be removed, fixing the dark mode problem.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image

How to set up and validate locally

  1. Check out this branch locally
  2. Ensure you are using dark mode in the GDK
  3. Visit the CI/CD Analytics > Lead time tab for a group in the GDK
  4. You will see that the text in the Lead time for changes chart is not black

Related to #452256 (closed), #425467 (closed)

Edited by Chad Lavimoniere

Merge request reports