Skip to content

Don't run assets and QA relevant jobs before approved

Lin Jen-Shin requested to merge 449031-no-production-assets-before-approval into master

What does this MR do and why?

Don't run build-assets-images, compile-production-assets, and build-qa-image before approved

This requires aligning with all the dependent jobs, meaning that we also no longer run some of the E2E tests under some conditions.

This also completes some of the missing parts from !145544 (merged)

The goal is the same. We don't want to run E2E tests and all relevant jobs before approval, unless really needed.

  • This also fixes that we run E2E tests when pipeline:run-all-e2e even when the merge request is not approved.

Break down of the intended behaviours:

Before approval

  • If pipeline:run-all-e2e is set, we run E2E tests automatically
  • If there are specific changes like qa-patterns, etc, we run E2E tests automatically
  • We provide a manual action FILL ME to trigger E2E tests otherwise.

After approval

  • Everything from before approval is still true after approval
  • If there are some other specific changes like dependency-patterns, etc, we run E2E tests automatically

How to validate

Testing this at !148195 (closed) for before approval and at !147915 (closed) for after approval.

Changing only to:

Before approval

After approval

Related to #449031 (closed)

Edited by Lin Jen-Shin

Merge request reports