Skip to content

Drop default rule_type when creating project approval rules

Lucas Charles requested to merge 9928-bugfix-drop-rule-default into master

What does this MR do?

Drop default rule_type when creating project approval rules

Project approval rules already have a default column rule_type set & shouldn't require an explicit one.

This actually interferes with ApprovalRules::CreateService which assumes an explicitly passed rule_type should be set by using a #reverse_merge. By dropping the forced default we can roll out a more gradual frontend update to trigger this behavior rather than require changes on both the backend and frontend

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Lucas Charles

Merge request reports