Skip to content

Add approval rules drawer to branch rules page

What does this MR do and why?

  1. Replaces the current Approval rules section with the shared approval rules app
  2. Ensures Editing/Adding approval rules use the approval rules drawer

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After After (add)
Screenshot_2024-03-26_at_16.20.00 Screenshot_2024-03-26_at_16.26.22 Screenshot_2024-03-26_at_16.26.37

How to set up and validate locally

  1. Enable the approval_rules_drawer feature flag
  2. Add a Branch rule
    • Navigate to Project > Repository > Settings > Branch rules > Add branch rule
  3. View the branch rule created in step 1
    • Navigate to Project > Repository > Settings > Branch rules > View details
  4. On the Branch rule details screen the Approval rules app should display and work as expected
  5. Edit/Add should should a drawer containing the approval rule form

Related to #439397 (closed)

Edited by Jacques Erasmus

Merge request reports