Group update_service, call super to allow CE to remove any params in `remove_unallowed_params`
What does this MR do?
remove_unallowed_params
is overridden in EE::Groups::UpdateService
, but super
is never called to give the base version a chance to remove any parameters.
Add the call to super
This is in support of work being done in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30755
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation created/updated or follow-up review issue created
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Brett Walker