Skip to content
Snippets Groups Projects

Extract isGroup and isProject to utils

Merged Artur Fedorov requested to merge 451931-policies-extract-methods-utils into master
All threads resolved!

What does this MR do and why?

This MR extracts common logic to utils

isGroup and isProject is widely used among security polices code. It is extracted to utils

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

***NO VISUAL CHANGES***

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

No steps required

Related to #451931 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Martin Čavoj requested review from @aturinske and removed review request for @mcavoj

    requested review from @aturinske and removed review request for @mcavoj

  • Martin Čavoj approved this merge request

    approved this merge request

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for d5f56132

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Package     | 24     | 0      | 6       | 0     | 30    | ✅     |
    | Create      | 77     | 0      | 9       | 0     | 86    | ✅     |
    | Plan        | 51     | 0      | 2       | 0     | 53    | ✅     |
    | Govern      | 66     | 0      | 0       | 0     | 66    | ✅     |
    | Data Stores | 31     | 0      | 0       | 0     | 31    | ✅     |
    | Verify      | 35     | 0      | 1       | 0     | 36    | ✅     |
    | Monitor     | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 298    | 0      | 19      | 0     | 317   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :x: test report for d5f56132

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Govern      | 271    | 1      | 19      | 0     | 291   | ❌     |
    | Create      | 152    | 0      | 21      | 2     | 173   | ✅     |
    | Package     | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Plan        | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Data Stores | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 443    | 1      | 42      | 2     | 486   | ❌     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Alexander Turinske
  • mentioned in merge request !147977 (merged)

  • Artur Fedorov added 78 commits

    added 78 commits

    Compare with previous version

  • Alexander Turinske approved this merge request

    approved this merge request

  • Alexander Turinske resolved all threads

    resolved all threads

  • Alexander Turinske enabled an automatic merge when the pipeline for fb3b593d succeeds

    enabled an automatic merge when the pipeline for fb3b593d succeeds

  • mentioned in commit 951bee69

  • changed milestone to %16.11

  • Please register or sign in to reply
    Loading