Extract isGroup and isProject to utils
What does this MR do and why?
This MR extracts common logic to utils
isGroup
and isProject
is widely used among security polices code. It is extracted to utils
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
***NO VISUAL CHANGES***
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
No steps required
Related to #451931 (closed)
Merge request reports
Activity
assigned to @arfedoro
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request does not refer to an existing milestone. 1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @viktomas
(UTC+2, same timezone as author)
@pgascouvaillancourt
(UTC-4, 6 hours behind author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 6b9b2a7b and d5f56132
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.25 MB 4.25 MB - 0.0 % mainChunk 3.22 MB 3.22 MB - 0.0 %
Note: We do not have exact data for 6b9b2a7b. So we have used data from: 949cd6e5.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 345 commits
-
eb7f4140...059269ce - 344 commits from branch
master
- 4b6303bc - This MR extracts common logic to utils
-
eb7f4140...059269ce - 344 commits from branch
added 556 commits
-
4b6303bc...60ba789e - 555 commits from branch
master
- 3b198cfd - This MR extracts common logic to utils
-
4b6303bc...60ba789e - 555 commits from branch
added 15 commits
-
3b198cfd...0865b43d - 14 commits from branch
master
- c1989d8e - This MR extracts common logic to utils
-
3b198cfd...0865b43d - 14 commits from branch
- Resolved by Artur Fedorov
@mcavoj could you please review this MR?
requested review from @mcavoj
- Resolved by Alexander Turinske
- Resolved by Alexander Turinske
requested review from @aturinske and removed review request for @mcavoj
added pipeline:mr-approved label
- Resolved by Alexander Turinske
@mcavoj
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for d5f56132expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Package | 24 | 0 | 6 | 0 | 30 | ✅ | | Create | 77 | 0 | 9 | 0 | 86 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 298 | 0 | 19 | 0 | 317 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for d5f56132expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 271 | 1 | 19 | 0 | 291 | ❌ | | Create | 152 | 0 | 21 | 2 | 173 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 443 | 1 | 42 | 2 | 486 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Alexander Turinske
- Resolved by Alexander Turinske
mentioned in merge request !147977 (merged)
added 78 commits
-
c1989d8e...f2458a2b - 76 commits from branch
master
- d4aff024 - This MR extracts common logic to utils
- d5f56132 - Applied review changes
-
c1989d8e...f2458a2b - 76 commits from branch
enabled an automatic merge when the pipeline for fb3b593d succeeds
mentioned in commit 951bee69
changed milestone to %16.11
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowproduction label and removed workflowcanary label
added workflowstaging label and removed workflowproduction label
added workflowpost-deploy-db-staging label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label