Skip to content

Fix milestone comparison

Manoj M J requested to merge mmj-fix-milestone-compare into master

What does this MR do and why?

irb(main):001:0> 16.11 >= 16.6
=> false

irb(main):001:0> '16.11' >= '16.6'
=> false

This means that simple float or string comparisons as we do today would not work for milestone comparisons. Since we are using semantic versioning, we need to compare versions as such, otherwise we will be getting wrong results. This MR fixes it.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Manoj M J

Merge request reports