Skip to content
Snippets Groups Projects

Move tracking for duo pro trial into service layer

Merged Doug Stull requested to merge 448506-move-and-deduplicate-tracking into master
All threads resolved!

What does this MR do and why?

Move tracking for duo pro trial into service layer

  • remove business logic from controller layer
  • adjust tests to only use shared example if used more than once
  • add tests to the service layer for tracking

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #448506

Edited by Doug Stull

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Doug Stull marked this merge request as ready

    marked this merge request as ready

  • Doug Stull added 1 commit

    added 1 commit

    • 3848e12c - Move tracking for duo pro trial into service layer

    Compare with previous version

  • Doug Stull changed the description

    changed the description

  • Doug Stull
  • Doug Stull
  • Doug Stull requested review from @rliu-gl

    requested review from @rliu-gl

  • added workflowin review label and removed workflowin dev label

  • Doug Stull requested review from @nbelokolodov

    requested review from @nbelokolodov

  • Niko Belokolodov approved this merge request

    approved this merge request

  • Niko Belokolodov removed review request for @nbelokolodov

    removed review request for @nbelokolodov

  • @dstull Some end-to-end (E2E) tests should run based on the stage label.

    Please start the manual:e2e-test-pipeline-generate job in the prepare stage and wait for the tests in the follow-up:e2e:package-and-test-ee pipeline to pass before merging this MR. Do not use Auto-merge, unless these tests have already completed successfully, because a failure in these tests do not block the auto-merge. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)

    To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.

    E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.

    Once done, apply the :white_check_mark: emoji on this comment.

    Team members only: for any questions or help, reach out on the internal #test-platform Slack channel.

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 3848e12c

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 90     | 0      | 9       | 0     | 99    | ✅     |
    | Plan        | 51     | 0      | 2       | 0     | 53    | ✅     |
    | Monitor     | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Govern      | 66     | 0      | 0       | 0     | 66    | ✅     |
    | Data Stores | 31     | 0      | 0       | 0     | 31    | ✅     |
    | Verify      | 35     | 0      | 1       | 0     | 36    | ✅     |
    | Package     | 24     | 0      | 6       | 0     | 30    | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 311    | 0      | 19      | 0     | 330   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :white_check_mark: test report for 3848e12c

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Growth      | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Create      | 152    | 0      | 21      | 2     | 173   | ✅     |
    | Package     | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Plan        | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Data Stores | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Govern      | 6      | 0      | 0       | 0     | 6     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 178    | 0      | 29      | 2     | 207   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Roy Liu approved this merge request

    approved this merge request

  • Roy Liu requested review from @brytannia and removed review request for @rliu-gl

    requested review from @brytannia and removed review request for @rliu-gl

  • Tetiana Chupryna requested review from @alipniagov and removed review request for @brytannia

    requested review from @alipniagov and removed review request for @brytannia

  • Aleksei Lipniagov approved this merge request

    approved this merge request

  • mentioned in issue #456098 (closed)

  • Aleksei Lipniagov resolved all threads

    resolved all threads

  • Aleksei Lipniagov enabled an automatic merge when the pipeline for 9fc61d7d succeeds

    enabled an automatic merge when the pipeline for 9fc61d7d succeeds

  • mentioned in commit 9dc6a504

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading