Move tracking for duo pro trial into service layer
What does this MR do and why?
Move tracking for duo pro trial into service layer
- remove business logic from controller layer
- adjust tests to only use shared example if used more than once
- add tests to the service layer for tracking
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #448506
Merge request reports
Activity
changed milestone to %16.11
assigned to @dstull
added maintenancerefactor typemaintenance labels and removed typefeature label
- A deleted user
added backend label
Reviewer roulette
Category Reviewer Maintainer analytics instrumentation @ankit.panchal
(UTC+5.5, 9.5 hours ahead of author)
Maintainer review is optional for analytics instrumentation backend @janis
(UTC+2, 6 hours ahead of author)
@drew
(UTC+0, 4 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1765 commits
-
34c91b41...a4b23d79 - 1764 commits from branch
master
- f979f9c7 - Move tracking for duo pro trial into service layer
-
34c91b41...a4b23d79 - 1764 commits from branch
- Resolved by Aleksei Lipniagov
added 1 commit
- 3848e12c - Move tracking for duo pro trial into service layer
- Resolved by Aleksei Lipniagov
- Resolved by Aleksei Lipniagov
- Resolved by Aleksei Lipniagov
requested review from @rliu-gl
added workflowin review label and removed workflowin dev label
- A deleted user
- Resolved by Aleksei Lipniagov
@nbelokolodov can you review for analytics instrumentation?
requested review from @nbelokolodov
added analytics instrumentationapproved label and removed analytics instrumentationreview pending label
removed review request for @nbelokolodov
added pipeline:mr-approved label
- Resolved by Aleksei Lipniagov
@nbelokolodov
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
@dstull Some end-to-end (E2E) tests should run based on the stage label.
Please start the
manual:e2e-test-pipeline-generate
job in theprepare
stage and wait for the tests in thefollow-up:e2e:package-and-test-ee
pipeline to pass before merging this MR. Do not use Auto-merge, unless these tests have already completed successfully, because a failure in these tests do not block the auto-merge. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.
E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.
Once done, apply the
emoji on this comment.Team members only: for any questions or help, reach out on the internal
#test-platform
Slack channel.E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 3848e12cexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 90 | 0 | 9 | 0 | 99 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Package | 24 | 0 | 6 | 0 | 30 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 311 | 0 | 19 | 0 | 330 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 3848e12cexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Growth | 0 | 0 | 6 | 0 | 6 | ➖ | | Create | 152 | 0 | 21 | 2 | 173 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 178 | 0 | 29 | 2 | 207 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
requested review from @brytannia and removed review request for @rliu-gl
requested review from @alipniagov and removed review request for @brytannia
mentioned in issue #456098 (closed)
enabled an automatic merge when the pipeline for 9fc61d7d succeeds
mentioned in commit 9dc6a504
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label