Skip to content

Merge PureFindingsFinder with FindingsFinder

Malcolm Locke requested to merge 444309-replace-pure-findings-finder into master

::Security::PureFindingsFinder is a "new" implementation of ::Security::FindingsFinder.

Now we have completed related data migrations we no longer need these 2 different finders.

To keep the naming sensible we are keeping the "old" finder name and moving the behaviour of PureFindingsFinder into FindingsFinder.

So although in this MR it appears we are removing the new finder, we are actually replacing the old finder with the new one.

The pricipal difference between these finders was that the old one would load finding data from the stored security reports, whereas the new one relies upon the finding data being available directly in the database. The calling endpoint code would switch between the 2 finder conditionally depending on whether or not all of the findings had their data stored in the database.

This is now true for all findings so the old code path will no longer be executed on production. However some of the tests were relying on this old code path and their setup had to be updated in this MR to exercise the new code. Therefore the test changes in this MR are a little more complicated than the code changes.

Related to #444309

Edited by Malcolm Locke

Merge request reports