Use textarea for collapsed snippet description
What does this MR do and why?
- Use 2-row
textarea
instead ofinput
for collapsed description box- Why? It looked weird/like a mistake having an single-row input for a description
- Use same snippet-specific placeholder across collapsed
textarea
and comment box
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
New snippet form
Links
Merge request reports
Activity
changed milestone to %16.11
added UX UX Paper Cuts frontend maintenanceusability typemaintenance labels
assigned to @annabeldunstone
- Resolved by Jacques Erasmus
@mle It seemed weird to see a small input for a
description
, even though we do expand it on click. What are your thoughts on this MR? Is the optional description taking up too much vertical space now?
Reviewer roulette
Category Reviewer Maintainer frontend @aalakkad
(UTC+3, 3 hours ahead of author)
@pslaughter
(UTC-5, 5 hours behind author)
UX @mle
(UTC+11, 11 hours ahead of author)
Maintainer review is optional for UX Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 48131a63 and e637e32f
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.24 MB 4.24 MB - 0.0 % mainChunk 3.22 MB 3.22 MB - 0.0 %
Note: We do not have exact data for 48131a63. So we have used data from: 6bf3d3b5.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangerrequested review from @mle
- Resolved by Michael Le
@annabeldunstone Thanks for this MR because it made me look at how the description is used and displayed.
There is a paper cut opportunity to tidy up the layout because when there is no description there is a lot of white space on the snippet.
removed review request for @mle
added 1 commit
- c6213368 - Use textarea for collapsed snippet description
requested review from @clavimoniere
added 1 commit
- e637e32f - Use textarea for collapsed snippet description
removed review request for @clavimoniere
added pipeline:mr-approved label
- Resolved by Jacques Erasmus
@clavimoniere
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added Category:Source Code Management label
requested review from @nradina
added devopscreate groupsource code sectiondev labels
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for e637e32fexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 62 | 0 | 4 | 0 | 66 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Create | 77 | 0 | 9 | 0 | 86 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 23 | 0 | 6 | 0 | 29 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 293 | 0 | 23 | 0 | 316 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for e637e32fexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 571 | 1 | 62 | 10 | 634 | ❌ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 597 | 1 | 64 | 10 | 662 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+
requested review from @jerasmus
enabled an automatic merge when the pipeline for b5842210 succeeds
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #6477309779 spec/features/users/snippets_spec.rb#L23
Snippets tab on a user profile when the user has snippets pagination behaves like paginated snippets is limited to 20 items per page 61.89 s < 50.13 s #6477309779 spec/features/users/snippets_spec.rb#L23
Snippets tab on a user profile when the user has snippets pagination behaves like paginated snippets clicking on the link to the second page shows the remaining snippets 62.09 s < 50.13 s #6477309779 spec/features/users/snippets_spec.rb#L32
Snippets tab on a user profile when the user has snippets list content contains only internal and public snippets of a user when a user is logged in 62.63 s < 50.13 s #6477309779 spec/features/users/snippets_spec.rb#L44
Snippets tab on a user profile when the user has snippets list content contains only public snippets of a user when a user is not logged in 62.02 s < 50.13 s - A deleted user
added rspec:slow test detected label
mentioned in commit c12ea77f
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2945 (merged)
mentioned in merge request !153682 (merged)
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label