Skip to content
Snippets Groups Projects

Use textarea for collapsed snippet description

Merged Annabel Dunstone Gray requested to merge new-snippet-form into master
All threads resolved!

What does this MR do and why?

  • Use 2-row textarea instead of input for collapsed description box
    • Why? It looked weird/like a mistake having an single-row input for a description
  • Use same snippet-specific placeholder across collapsed textarea and comment box

Screenshots or screen recordings

Before After
Screenshot_2024-03-21_at_11.38.52_AM Screenshot_2024-03-22_at_6.34.10_AM
Screenshot_2024-03-22_at_6.35.04_AM Screenshot_2024-03-22_at_6.34.18_AM

How to set up and validate locally

New snippet form

Links

Edited by Annabel Dunstone Gray

Merge request reports

Merged results pipeline #1227661114 passed

Pipeline: E2E GDK

#1227675522

    Pipeline: GitLab

    #1227680099

      Pipeline: TRIGGERED_EE_PIPELINE

      #1227696394

        +3

        Merged results pipeline passed for b5842210

        Test coverage 81.45% (16.66%) from 2 jobs
        Approved by

        Merged by Jacques ErasmusJacques Erasmus 11 months ago (Mar 26, 2024 10:52am UTC)

        Merge details

        • Changes merged into master with c12ea77f (commits were squashed).
        • Deleted the source branch.
        • Auto-merge enabled

        Pipeline #1227841090 passed

        Pipeline passed for c12ea77f on master

        Test coverage 64.66% (16.66%) from 2 jobs
        10 environments impacted.

        Activity

        Filter activity
        • Approvals
        • Assignees & reviewers
        • Comments (from bots)
        • Comments (from users)
        • Commits & branches
        • Edits
        • Labels
        • Lock status
        • Mentions
        • Merge request status
        • Tracking
        Please register or sign in to reply
        Loading