Skip to content

Use Progressive Web App (PWA) icon as apple-touch-icon if defined

Roger Meier requested to merge gitlab-community/gitlab:feat/use-pwa-icon-as-apple-touch-icon-if-defined into master

What does this MR do and why?

Use Progressive Web App (PWA) icon as apple-touch-icon if defined

When adding GitLab to the homescreen on an Apple device the default icon apple-touch-icon.png is used. This is hardcoded and therfore on self-hosted instances the GitLab logo is shown. As the pwa icon fullfills the same purpose in an standardized way, we can use it as apple-touch-icon if defined.

Further references regarding "apple-touch-icon":

Closes: #358124

Changelog: added

🛠 with ❤ at Siemens

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

  1. check page source, should contain <link rel="apple-touch-icon" type="image/x-icon" href="/assets/apple-touch-icon-b049d4bc0dd9626f31db825d61880737befc7835982586d015bded10b4435460.png">
  2. add a PWA icon via http://127.0.0.1:3000/admin/application_settings/appearance
  3. check the source, it should have three <link rel="apple-touch-icon" entries

Numbered steps to set up and validate the change are strongly suggested.

Edited by Roger Meier

Merge request reports