Extract security dashboard permissions
What does this MR do?
This is the 4th MR of 5 towards separating the project security dashboard from the group security dashboard's vulnerabilities endpoints. Once all 5 have been merged, it will solve 2 bugs: https://gitlab.com/gitlab-org/gitlab-ee/issues/12381, https://gitlab.com/gitlab-org/gitlab-ee/issues/12244
In both bug issues you can see the previous 3 MRs, which have also extracted functionality that will be shared between the dashboards.
This MR extracts the permissions we use for Groups::Security::VulnerabilitiesController so that we can reuse them in the Projects::Security::VulnerabilitiesController which will be introduced in the next MR.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team