Skip to content

Fixes requesting a new review not unapproving reviewers

Phil Hughes requested to merge ph/451020/fixRemoveApproval into master

What does this MR do and why?

Fixes a bug where approvals would not get removed when a reviewer who has already approved gets a new review requested.

#451020 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

How to set up and validate locally

  • Visit a merge request approved by another user (not the one you are signed in as)
  • Click request new review in sidebar
  • Approval should be removed with a new system note created

Merge request reports