Update deprecation milestone for job token setting
What does this MR do and why?
As per the related MR, we need to update deprecation milestone for the job token setting in the UI and API docs as well.
While looking at the UI text, I realized we also needed to clarify the message, as the setting names changed in 16.3 but we never updated the deprecation warning to match.
- Related to !146947 (merged)
- Related to https://gitlab.com/gitlab-com/Product/-/issues/13137#note_1806437438
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before |
---|
![]() |
After |
---|
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
changed milestone to %16.11
assigned to @marcel.amirault
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/project_job_token_scopes.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Category Reviewer Maintainer frontend @dftian
(UTC-10, 19 hours behind author)
@iamphill
(UTC+0, 9 hours behind author)
~"Verify" Reviewer review is optional for ~"Verify" @jivanvl
(UTC-6, 15 hours behind author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits b3dd2827 and 87a5f32c
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.24 MB 4.24 MB - 0.0 % mainChunk 3.22 MB 3.22 MB - 0.0 %
Note: We do not have exact data for b3dd2827. So we have used data from: b4ddf483.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 1 commit
- 3a427d58 - Update deprecation milestone for job token setting
requested review from @mgandres and @bonnie-tsang
- Resolved by Mireya Andres
@mgandres Could you take a look? I suspect this isn't good code, but it was what I managed to hack together to make it look right... Can you help me code this properly, but I want it to look exactly as-is in the screenshot
@bonnie-tsang Can you take a look from the UX perspective, especially the updated messaging?
cc @jocelynjane
added 17 commits
-
3a427d58...f2ea8e9c - 16 commits from branch
master
- 353a6601 - Update deprecation milestone for job token setting
-
3a427d58...f2ea8e9c - 16 commits from branch
- Resolved by Mireya Andres
added 284 commits
-
353a6601...8dea6025 - 282 commits from branch
master
- 84e405b5 - Update deprecation milestone for job token setting
- 87a5f32c - Rename italic to italicAndBold
-
353a6601...8dea6025 - 282 commits from branch
added pipeline:mr-approved label
- Resolved by Mireya Andres
@bonnie-tsang
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 87a5f32cexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 26 | 0 | 3 | 0 | 29 | ✅ | | Create | 66 | 0 | 9 | 0 | 75 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 289 | 0 | 16 | 0 | 305 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
enabled an automatic merge when the pipeline for ba867e8e succeeds
mentioned in commit 8efdeac8
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
mentioned in issue #453977 (closed)
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2945 (merged)
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label