Skip to content

Resolve "Add inline validation to admin deletion protection settings"

Peter Hegman requested to merge 364133-add-inline-validation-to-admin-deletion-protection-settings into master

What does this MR do and why?

Related to #364133 (closed)

Finishing up community contribution that author was not able to finish (!138026 (merged)).

This MR adds inline validation to the Deletion protection setting in Admin area -> Settings -> General -> Visibility and access controls

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Screenshot_2024-03-21_at_12.04.37_PM Screenshot_2024-03-21_at_12.08.46_PM
Screenshot_2024-03-21_at_12.04.49_PM Screenshot_2024-03-21_at_12.08.58_PM

How to set up and validate locally

  1. Sign in as an admin
  2. Navigate to /admin/application_settings/general
  3. In the Deletion protection field enter 0 or 91
  4. Hit enter or tab
Edited by Peter Hegman

Merge request reports