Skip to content

Upgrade gitlab-fog-azure-rm to v1.9.1

Stan Hu requested to merge sh-upgrade-azure-fog-gem into master

What does this MR do and why?

send_file_upload attempts to set response-content-type via a query parameter, but this previously only worked for fog-aws and fog-google. For Azure, we need to convert this query parameter for the Azure Blob Storage client, which converts the content_type argument to a SAS rsct parameter. This is done in gitlab-org/ruby/gems/gitlab-fog-azure-rm!44 (merged).

Previously the dependency proxy did not work since the gitlab-fog-azure-rm did not convert this query argument properly.

This change makes the dependency proxy work with Azure Blob Storage.

Relates to #352551 (closed)

How to set up and validate locally

  1. Enable the dependency proxy for a group: https://docs.gitlab.com/ee/user/packages/dependency_proxy/
  2. Set up Azure in the gdk.yml:
object_store:
  connection:
    provider: AzureRM
    azure_storage_account_name: YOUR-ACCOUNT-NAME
    azure_storage_access_key: REDACTED
  consolidated_form: true
  enabled: true
  objects:
    artifacts:
      bucket: test1/artifacts
    external_diffs:
      bucket: test1/external_diffs
    lfs:
      bucket: test1/lfs
    uploads:
      bucket: test1/uploads
    packages:
      bucket: test1/packages
    dependency_proxy:
      bucket: test1/dependency-proxy
    terraform_state:
      bucket: test1/terraform
    pages:
      bucket: test1/pages
    ci_secure_files:
      bucket: test1/ci_secure_files
    gitaly_backups:
      bucket: test1/gitaly_backups
  1. Run gdk reconfigure
  2. Run docker pull gdk.host:3443/your-group/dependency_proxy/containers/alpine:latest.
  3. On master, this fails with a missing signature key.
  4. On this branch, it works.
Edited by Stan Hu

Merge request reports