Skip to content
Snippets Groups Projects

Remove frontend code for security_auto_fix with functionalities

Merged Zamir Martins requested to merge remove_frontend_code_for_security_auto_fix into master
All threads resolved!

What does this MR do and why?

Remove frontend code for security_auto_fix with functionalities.

Related issue: [Feature flag] Cleanup security_auto_fix (#435432 - closed) • Zamir Martins • 17.0 • Needs attention

Follow-up from: Remove auto fix worker with migration (!147051 - merged) • Zamir Martins • 16.11

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-03-13_at_18.01.20 Screenshot_2024-03-13_at_18.02.18

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Zamir Martins

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Fernando Cardenas
    • Resolved by Ezekiel Kigbo

      question (blocking)

      Could you please clarify if there is a separate frontend removal isssue to remove usages of security_auto_fix in the haml templates. I found a few occurrences here in the attatched screenshot.

      We should remove the following:

      • push_frontend_feature_flag(:security_auto_fix) calls
      • Unit tests that use stub_feature_flags(security_auto_fix: <boolean>)
      • Feature.enabled?(:security_auto_fix) logic in HAMl templates.

      Screenshot_2024-03-15_at_3.14.21_PM

      Edited by Fernando Cardenas
  • requested review from @zmartins

  • Zamir Martins added 41 commits

    added 41 commits

    Compare with previous version

  • Zamir Martins removed review request for @zmartins

    removed review request for @zmartins

  • Fernando Cardenas approved this merge request

    approved this merge request

  • @zmartins Some end-to-end (E2E) tests should run based on the stage label.

    Please start the trigger-omnibus-and-follow-up-e2e job in the qa stage and wait for the tests in the follow-up-e2e:package-and-test-ee pipeline to pass before merging this MR. Do not use Auto-merge, unless these tests have already completed successfully, because a failure in these tests do not block the auto-merge. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)

    To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.

    E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.

    Once done, apply the :white_check_mark: emoji on this comment.

    Team members only: for any questions or help, reach out on the internal #test-platform Slack channel.

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for f4d3dd12

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Monitor     | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Govern      | 3      | 0      | 0       | 0     | 3     | ✅     |
    | Plan        | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Create      | 8      | 0      | 3       | 0     | 11    | ✅     |
    | Data Stores | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Package     | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 21     | 0      | 4       | 0     | 25    | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-review-qa: :white_check_mark: test report for f4d3dd12

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 8      | 0      | 3       | 0     | 11    | ✅     |
    | Package     | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Govern      | 3      | 0      | 0       | 0     | 3     | ✅     |
    | Monitor     | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Data Stores | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Plan        | 3      | 0      | 1       | 0     | 4     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 20     | 0      | 5       | 0     | 25    | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Zamir Martins requested review from @ekigbo

    requested review from @ekigbo

  • Ezekiel Kigbo approved this merge request

    approved this merge request

  • Ezekiel Kigbo resolved all threads

    resolved all threads

  • Ezekiel Kigbo enabled an automatic merge when the pipeline for 1dc643d8 succeeds

    enabled an automatic merge when the pipeline for 1dc643d8 succeeds

  • @ekigbo, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:

    1. Ensure the merge request is not in Draft status.
    2. Start a pipeline (especially important for Community contribution merge requests).
    3. Set the merge request to auto-merge.

    This is a guideline, not a rule. Please consider replying to this comment for transparency.

    This message was generated automatically. You're welcome to improve it.

  • Ezekiel Kigbo mentioned in commit cc0a8425

    mentioned in commit cc0a8425

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading