Remove frontend code for security_auto_fix with functionalities
What does this MR do and why?
Remove frontend code for security_auto_fix with functionalities.
Related issue: [Feature flag] Cleanup security_auto_fix (#435432 - closed) • Zamir Martins • 17.0 • Needs attention
Follow-up from: Remove auto fix worker with migration (!147051 - merged) • Zamir Martins • 16.11
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
changed milestone to %16.11
assigned to @zmartins
1 Warning This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:ee/app/assets/javascripts/security_dashboard/components/shared/project_pipeline_status.vue
- <div v-if="autoFixMrsCount" class="gl-md-ml-3" data-testid="auto-fix-mrs-link">
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start thetrigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure the tests infollow-up-e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @andrei.zubov
(UTC+1, same timezone as author)
@vitallium
(UTC+1, same timezone as author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- afca084c - Remove frontend code for security_auto_fix with
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 6ece5c34 and f4d3dd12
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.24 MB 4.24 MB - -0.0 % mainChunk 3.22 MB 3.22 MB - 0.0 %
Note: We do not have exact data for 6ece5c34. So we have used data from: 5b95c8f5.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 1 commit
- f74583bc - Remove frontend code for security_auto_fix with
added 1 commit
- 4607771a - Remove frontend code for security_auto_fix with
added 1 commit
- 4c2ce8d8 - Remove frontend code for security_auto_fix with
added 57 commits
-
4c2ce8d8...b2e4170f - 56 commits from branch
master
- 835cc59c - Remove frontend code for security_auto_fix with
-
4c2ce8d8...b2e4170f - 56 commits from branch
- Resolved by Ezekiel Kigbo
@fernando-c I have been tackling #435432 (closed) and I was wondering if you could perform the initial review due to your familiarity here.
requested review from @fernando-c
- Resolved by Ezekiel Kigbo
@pgascouvaillancourt I was looking at one of your old commits f6f4d8b4
It looks like security_auto_fix is dead code we never got around to enabling. As far as the UI goes, any chance you recall any other bits of useful information, or caveats to removing this code?
Any other places in the UI it might pop up?
It's over 3 years ago, so I understand if not. I will do this MR review, but figured I'd ask just in case.
Edited by Fernando Cardenas
mentioned in merge request !147157 (merged)
mentioned in merge request !147161 (merged)
mentioned in merge request !147202 (merged)
added 91 commits
-
835cc59c...3ec753ba - 90 commits from branch
master
- 8d3bc295 - Remove frontend code for security_auto_fix with
-
835cc59c...3ec753ba - 90 commits from branch
- Resolved by Ezekiel Kigbo
- Resolved by Ezekiel Kigbo
- Resolved by Ezekiel Kigbo
question (blocking)
Could you please clarify if there is a separate frontend removal isssue to remove usages of
security_auto_fix
in the haml templates. I found a few occurrences here in the attatched screenshot.We should remove the following:
-
push_frontend_feature_flag(:security_auto_fix)
calls - Unit tests that use
stub_feature_flags(security_auto_fix: <boolean>)
-
Feature.enabled?(:security_auto_fix)
logic in HAMl templates.
Edited by Fernando Cardenas -
- Resolved by Ezekiel Kigbo
@zmartins so far the progress in the MR looks good. There are still parts of the frontend that still need to be cleaned up.
They are Rails view HAML and Controller usages, I'm ok with it being removed in a following issue if you could link me to it, or create one. See the comment in the thread above.
Edited by Fernando Cardenas
requested review from @zmartins
added 41 commits
-
8d3bc295...fd056dfa - 40 commits from branch
master
- f4d3dd12 - Remove frontend code for security_auto_fix with
-
8d3bc295...fd056dfa - 40 commits from branch
removed review request for @zmartins
added pipeline:mr-approved label
- Resolved by Ezekiel Kigbo
@fernando-c
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
@zmartins Some end-to-end (E2E) tests should run based on the stage label.
Please start the
trigger-omnibus-and-follow-up-e2e
job in theqa
stage and wait for the tests in thefollow-up-e2e:package-and-test-ee
pipeline to pass before merging this MR. Do not use Auto-merge, unless these tests have already completed successfully, because a failure in these tests do not block the auto-merge. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.
E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.
Once done, apply the
emoji on this comment.Team members only: for any questions or help, reach out on the internal
#test-platform
Slack channel.E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for f4d3dd12expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 8 | 0 | 3 | 0 | 11 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 4 | 0 | 25 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for f4d3dd12expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 3 | 0 | 11 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 5 | 0 | 25 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Ezekiel Kigbo
@ekigbo Would you perform the maintainer review ?
requested review from @ekigbo
enabled an automatic merge when the pipeline for 1dc643d8 succeeds
@ekigbo, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit cc0a8425
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2945 (merged)
mentioned in merge request gitlab-com/www-gitlab-com!134357
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label