Skip to content

Add approval rule drawer to MR edit

Jacques Erasmus requested to merge 439397-mr-edit-approval-rules-drawer into master

What does this MR do and why?

Replaces the approval rule modal with a drawer when creating/editing an MR.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-03-14_at_09.53.42 Screenshot_2024-03-14_at_09.54.16

Screen_Recording_2024-03-14_at_09.56.27.2024-03-14_09_57_41

How to set up and validate locally

  1. Enable the approval_rules_drawer feature flag.
  2. Create or Edit a merge request.
  3. In the merge request Create/Edit form expand the Approval rule accordion.
  4. Adding, Editing and Deleting a rule should work as expected.

Related to #439397 (closed)

Edited by Jacques Erasmus

Merge request reports