Skip to content

Adds support for aria-label in `icons_helper#sprite_icon` method

Rahul Chanila requested to merge 443572-adds-support-for-aria-label-sprite-icon-helper into master

What does this MR do and why?

Adds support for aria-label in icons_helper#sprite_icon method

Updates Google Artifact Registry integration field with aria-label for external link.

Resolves discussion.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Google Artifact Registry example:

Before After
Screenshot_2024-03-08_at_10.31.34_pm Screenshot_2024-03-08_at_10.25.49_pm

How to set up and validate locally

  1. Simulate a SAAS instance in local GDK

  2. In rails console enable the experiment

    Feature.enable(:google_cloud_support_feature_flag)

  3. Visit Project > Settings > Integrations > Google Cloud IAM and complete the fields with random values.

  4. Visit Project > Settings > Integrations > Google Artifact Registry

  5. Using screenreader, make sure external link is announced when reading the Where's my project ID link.

Related to #443572 (closed)

Edited by Rahul Chanila

Merge request reports