Skip to content

Prevent browser notifications on initial load

Heinrich Lee Yu requested to merge fix-mr-notification-on-initial-load into master

What does this MR do and why?

The browser notifications for pipeline status changes should only be triggered if the status changes while the page is already opened. The initial load should not trigger a notification.

This fixes a regression from !146048 (merged)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. Make sure browser notifications are enabled

    Screenshot_2024-03-09_at_6.42.12_AM

  2. Open an MR that has a pipeline

  3. Browser popup notification should not show up on initial load

    Screenshot_2024-03-09_at_8.01.11_AM

Edited by Heinrich Lee Yu

Merge request reports