Skip to content

Fix failing spec/scripts/internal_events/cli_spec.rb test

Stan Hu requested to merge sh-fix-issue-448636 into master

What does this MR do and why?

spec/scripts/internal_events/cli_spec.rb attempts to look at a mocked TTY output to see if the CLI worked as behaved. However, the test started to fail because the output grew to 622 lines. However, the test looked only at the last 320 lines, but not all the expected outputs were contained in that window.

To fix this test, just look through the entire buffer instead of trying to limit by hundreds of rows.

Relates to #448636 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

bundle exec rspec ./spec/scripts/internal_events/cli_spec.rb:664 
Edited by Stan Hu

Merge request reports