Skip to content
Snippets Groups Projects

Fix sidebar padding problem for issue lists

Merged Chad Lavimoniere requested to merge 20240307-cl-issue-list-sidebar-padding into master
All threads resolved!

What does this MR do and why?

Issue lists never have a collapsed sidebar, but they had previously shown a gap at the right to accommodate a collapsed sidebar at small viewport sizes. This fixes that, and fixes a subtle bug that caused that right side padding to be re-added when the issue bulk edit sidebar was opened.

cf. also !146394 (comment 1806423773), where @pslaughter recommends 3 of the 4 changes in this MR.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
image image
bulk-edit-sidebar-before Screen_Recording_2024-03-07_at_18.42.48

How to set up and validate locally

  1. Check out this branch locally
  2. Visit an issues or Epics list page
  3. Set your viewport width to 700px (this only affects viewports in the sm breakpoint)
    • You should see that there is not a large gap at the right of the page created by a 62px right padding on the content-wrapper div.
  4. Click the "Bulk edit" button
    • You should see that the page contents does not get shifted to the left by a 62px wide right padding that is added to the content-wrapper div.

Related to #425467 (closed)

Edited by Chad Lavimoniere

Merge request reports

Merged results pipeline #1212339003 passed

Pipeline: Ruby 3.1 as-if-foss pipeline

#1212343415

    Pipeline: GitLab

    #1212358137

      Pipeline: GitLab

      #1212347744

        +3

        Merged results pipeline passed for 703d6c54

        Test coverage 81.50% (16.71%) from 2 jobs

        Merged by Paul SlaughterPaul Slaughter 11 months ago (Mar 13, 2024 7:54pm UTC)

        Loading

        Pipeline #1212552511 passed with warnings

        Pipeline: [gitlab-schema-validation gem] Ruby 3.0 pipeline

        #1212552745

          Pipeline: [diff_match_patch gem] Ruby 3.0 pipeline

          #1212552746

            Pipeline: [gitlab-housekeeper gem] Ruby 3.0 pipeline

            #1212552731

              +29

              Pipeline passed with warnings for 042b8774 on master

              Test coverage 73.04% (16.71%) from 2 jobs
              6 environments impacted.

              Activity

              Filter activity
              • Approvals
              • Assignees & reviewers
              • Comments (from bots)
              • Comments (from users)
              • Commits & branches
              • Edits
              • Labels
              • Lock status
              • Mentions
              • Merge request status
              • Tracking
            • A deleted user added backend frontend labels

              added backend frontend labels

            • 1 Warning
              :warning:

              This merge request changed undocumented Vue components in vue_shared/. Please consider creating Stories for these components:

              • app/assets/javascripts/vue_shared/issuable/list/components/issuable_bulk_edit_sidebar.vue

              Reviewer roulette

              Category Reviewer Maintainer
              backend @atiwari71 profile link current availability (UTC-7, same timezone as author) @kerrizor profile link current availability (UTC-7, same timezone as author)
              frontend @dftian profile link current availability (UTC-10, 3 hours behind author) @slashmanov profile link current availability (UTC+4, 11 hours ahead of author)

              Please check reviewer's status!

              • available Reviewer is available!
              • unavailable Reviewer is unavailable!

              Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

              If needed, you can retry the :repeat: danger-review job that generated this comment.

              Generated by :no_entry_sign: Danger

            • Chad Lavimoniere changed the description

              changed the description

            • Bundle size analysis [beta]

              This compares changes in bundle size for entry points between the commits 7f90e51c and e97e31aa

              :sparkles: Special assets

              Entrypoint / Name Size before Size after Diff Diff in percent
              average 4.23 MB 4.23 MB - 0.0 %
              mainChunk 3.22 MB 3.22 MB - 0.0 %

              Note: We do not have exact data for 7f90e51c. So we have used data from: 3c1cfb22.
              The intended commit has no webpack pipeline, so we chose the last commit with one before it.

              Please look at the full report for more details


              Read more about how this report works.

              Generated by :no_entry_sign: Danger

            • Paul Slaughter removed review request for @pslaughter

              removed review request for @pslaughter

            • added 1 commit

              • e97e31aa - Fix sidebar padding problem for issue lists

              Compare with previous version

            • A deleted user added backend frontend labels

              added backend frontend labels

            • requested review from @pslaughter

            • Paul Slaughter resolved all threads

              resolved all threads

            • Thanks for working on this @clavimoniere! Changes LGTM :thumbsup:

              lgtm

              Approving and starting merge...

            • Paul Slaughter approved this merge request

              approved this merge request

            • Paul Slaughter resolved all threads

              resolved all threads

            • E2E Test Result Summary

              allure-report-publisher generated test report!

              e2e-test-on-gdk: :white_check_mark: test report for e97e31aa

              expand test summary
              +------------------------------------------------------------------+
              |                          suites summary                          |
              +-------------+--------+--------+---------+-------+-------+--------+
              |             | passed | failed | skipped | flaky | total | result |
              +-------------+--------+--------+---------+-------+-------+--------+
              | Govern      | 3      | 0      | 0       | 0     | 3     | ✅     |
              | Monitor     | 4      | 0      | 0       | 0     | 4     | ✅     |
              | Plan        | 51     | 0      | 2       | 0     | 53    | ✅     |
              | Create      | 8      | 0      | 3       | 0     | 11    | ✅     |
              | Package     | 0      | 0      | 1       | 0     | 1     | ➖     |
              | Data Stores | 2      | 0      | 0       | 0     | 2     | ✅     |
              +-------------+--------+--------+---------+-------+-------+--------+
              | Total       | 68     | 0      | 6       | 0     | 74    | ✅     |
              +-------------+--------+--------+---------+-------+-------+--------+

              e2e-review-qa: :white_check_mark: test report for e97e31aa

              expand test summary
              +------------------------------------------------------------------+
              |                          suites summary                          |
              +-------------+--------+--------+---------+-------+-------+--------+
              |             | passed | failed | skipped | flaky | total | result |
              +-------------+--------+--------+---------+-------+-------+--------+
              | Create      | 8      | 0      | 3       | 4     | 11    | ✅     |
              | Monitor     | 4      | 0      | 0       | 0     | 4     | ✅     |
              | Govern      | 3      | 0      | 0       | 0     | 3     | ✅     |
              | Data Stores | 2      | 0      | 0       | 0     | 2     | ✅     |
              | Plan        | 3      | 0      | 1       | 2     | 4     | ✅     |
              | Package     | 0      | 0      | 1       | 0     | 1     | ➖     |
              +-------------+--------+--------+---------+-------+-------+--------+
              | Total       | 20     | 0      | 5       | 6     | 25    | ✅     |
              +-------------+--------+--------+---------+-------+-------+--------+

              e2e-package-and-test: :white_check_mark: test report for e97e31aa

              expand test summary
              +------------------------------------------------------------------+
              |                          suites summary                          |
              +-------------+--------+--------+---------+-------+-------+--------+
              |             | passed | failed | skipped | flaky | total | result |
              +-------------+--------+--------+---------+-------+-------+--------+
              | Plan        | 249    | 0      | 19      | 0     | 268   | ✅     |
              | Create      | 153    | 0      | 20      | 0     | 173   | ✅     |
              | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
              | Data Stores | 4      | 0      | 0       | 0     | 4     | ✅     |
              | Govern      | 6      | 0      | 0       | 0     | 6     | ✅     |
              | Package     | 0      | 0      | 2       | 0     | 2     | ➖     |
              +-------------+--------+--------+---------+-------+-------+--------+
              | Total       | 420    | 0      | 41      | 0     | 461   | ✅     |
              +-------------+--------+--------+---------+-------+-------+--------+
            • Paul Slaughter enabled an automatic merge when the pipeline for 703d6c54 succeeds

              enabled an automatic merge when the pipeline for 703d6c54 succeeds

            • mentioned in commit 042b8774

            • Chad Lavimoniere changed the description

              changed the description

            • Please register or sign in to reply
              Loading