Fix sidebar padding problem for issue lists
What does this MR do and why?
Issue lists never have a collapsed sidebar, but they had previously shown a gap at the right to accommodate a collapsed sidebar at small viewport sizes. This fixes that, and fixes a subtle bug that caused that right side padding to be re-added when the issue bulk edit sidebar was opened.
cf. also !146394 (comment 1806423773), where @pslaughter recommends 3 of the 4 changes in this MR.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
bulk-edit-sidebar-before | Screen_Recording_2024-03-07_at_18.42.48 |
How to set up and validate locally
- Check out this branch locally
- Visit an issues or Epics list page
- Set your viewport width to 700px (this only affects viewports in the
sm
breakpoint)- You should see that there is not a large gap at the right of the page created by a 62px right padding on the
content-wrapper
div.
- You should see that there is not a large gap at the right of the page created by a 62px right padding on the
- Click the "Bulk edit" button
- You should see that the page contents does not get shifted to the left by a 62px wide right padding that is added to the
content-wrapper
div.
- You should see that the page contents does not get shifted to the left by a 62px wide right padding that is added to the
Related to #425467 (closed)
Merge request reports
Activity
changed milestone to %16.11
added UX Paper Cuts bugux devopsplan groupproject management severity4 typebug + 1 deleted label
requested review from @pslaughter
assigned to @clavimoniere
added Category:Team Planning sectiondev labels
- Resolved by Chad Lavimoniere
1 Warning This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/issuable/list/components/issuable_bulk_edit_sidebar.vue
Reviewer roulette
Category Reviewer Maintainer backend @atiwari71
(UTC-7, same timezone as author)
@kerrizor
(UTC-7, same timezone as author)
frontend @dftian
(UTC-10, 3 hours behind author)
@slashmanov
(UTC+4, 11 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 7f90e51c and e97e31aa
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.23 MB 4.23 MB - 0.0 % mainChunk 3.22 MB 3.22 MB - 0.0 %
Note: We do not have exact data for 7f90e51c. So we have used data from: 3c1cfb22.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Chad Lavimoniere
Looking at this now!
- Resolved by Paul Slaughter
Thanks so much for working on this @clavimoniere! There's a small suggestion for you, then we should be good to go.
Back to you!
removed review request for @pslaughter
requested review from @pslaughter
added pipeline:mr-approved label
- Resolved by Paul Slaughter
@pslaughter
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for e97e31aaexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Create | 8 | 0 | 3 | 0 | 11 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 68 | 0 | 6 | 0 | 74 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for e97e31aaexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 3 | 4 | 11 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 3 | 0 | 1 | 2 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 5 | 6 | 25 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for e97e31aaexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 249 | 0 | 19 | 0 | 268 | ✅ | | Create | 153 | 0 | 20 | 0 | 173 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 420 | 0 | 41 | 0 | 461 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
enabled an automatic merge when the pipeline for 703d6c54 succeeds
mentioned in commit 042b8774
added workflowpost-deploy-db-staging label
mentioned in merge request kubitus-project/kubitus-installer!2869 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label