Skip to content

Fix sidebar padding problem for issue lists

Chad Lavimoniere requested to merge 20240307-cl-issue-list-sidebar-padding into master

What does this MR do and why?

Issue lists never have a collapsed sidebar, but they had previously shown a gap at the right to accommodate a collapsed sidebar at small viewport sizes. This fixes that, and fixes a subtle bug that caused that right side padding to be re-added when the issue bulk edit sidebar was opened.

cf. also !146394 (comment 1806423773), where @pslaughter recommends 3 of the 4 changes in this MR.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
image image
bulk-edit-sidebar-before Screen_Recording_2024-03-07_at_18.42.48

How to set up and validate locally

  1. Check out this branch locally
  2. Visit an issues or Epics list page
  3. Set your viewport width to 700px (this only affects viewports in the sm breakpoint)
    • You should see that there is not a large gap at the right of the page created by a 62px right padding on the content-wrapper div.
  4. Click the "Bulk edit" button
    • You should see that the page contents does not get shifted to the left by a 62px wide right padding that is added to the content-wrapper div.

Related to #425467 (closed)

Edited by Chad Lavimoniere

Merge request reports