Skip to content

Change schema of multiple tables

Manoj M J requested to merge manojmj-master-patch-64563 into master

What does this MR do and why?

While going through database dictionary files, I noticed that security_findings has gitlab_schema of gitlab_main, but it has a sharding key defined.

On digging further, I noticed a total have 4 tables have this discrepancy, ie, they have a sharding key or desired sharding key defined, but the schema is still assigned as gitlab_main, whereas it should be gitlab_main_cell instead.

I've corrected this and also added specs to make sure that this is not allowed from now.

The added specs would function like so:

Sharding key spec Desired sharding key spec
Screenshot_2024-03-07_at_2.30.35_PM Screenshot_2024-03-07_at_2.33.37_PM

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Manoj M J

Merge request reports