Skip to content

E2E test: allow max_attempts to be defined for push

Jay McCure requested to merge jmc-push-rules-slow-spec into master

What does this MR do and why?

qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb is above the 5 minute threshold for E2E tests, coming in at 7.38 minutes, this MR reduces the duration of these tests.

Resolves: #444291 (closed) which was created from https://gitlab.slack.com/archives/C02MH85L5EF/p1710730961630359

Repository push is attempted 3 times with a 10 second intervals to reduce flakiness, however some specs expect an error when pushing. This MR allows us to set the max attempts, so in the case where we expect an error we only attempt the push once.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Recent master run for comparison: https://gitlab-qa-allure-reports.s3.amazonaws.com/e2e-package-and-test/master/1221754144/index.html#suites/d225c9add4e032b7c04e2143e7d96217

This MR (left) / Master (right) (the tests which test for a push restriction are 15s - 30s faster per test)

Screenshot_2024-03-22_at_13.30.07

Screenshot_2024-03-22_at_13.29.31

Edited by Jay McCure

Merge request reports