Skip to content

Resolve validation failing for theme_id when previous dark mode value 11

Scott de Jonge requested to merge 447494-okta-sign-in-is-broken-for-dark-mode-users into master

What does this MR do and why?

Add DEPRECATED_DARK_THEME_ID equal to 11 for previous dark mode theme, to list of valid_ids in theme model

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After

How to set up and validate locally

To reproduce Okta validation error follow reproduction steps in #447494 (closed)

  1. Set theme_id to 11 by selecting "Dark mode (alpha)" theme in profile preferences http://gitlab.com/-/profile/preferences
  2. If you cannot see "Dark mode (alpha)" theme, toggle "Next" to false https://next.gitlab.com/

Related to #447494 (closed)

Edited by Scott de Jonge

Merge request reports