Skip to content

Cleanup unused deprecated native checkbox element

Taras Tadai requested to merge 446219-remove-unused-deprecated-checkbox into master

What does this MR do and why?

Detected usage of native checkbox usage inside HAML file that must be migrated to Pajamas::CheckboxComponent.

It's a part of Pajamas adoption project

UPDATE: After some discussions we decided to remove the file with checkbox component as not used.

I see we added this checkbox here cca4a5fd and it was rendered only from next files:

  • app/views/shared/boards/components/sidebar/_labels.html.haml
  • app/views/shared/issuable/_board_create_list_dropdown.html.haml

according to passed , locals: { show_add_list: true } while rendering = render partial: "shared/issuable/label_page_create", locals: { show_add_list: true }

Later we removed both files:

  • app/views/shared/boards/components/sidebar/_labels.html.haml here 58f5d646
  • app/views/shared/issuable/_board_create_list_dropdown.html.haml here !59826 (diffs)

I don't see we pass this , locals: { show_add_list: true } anywhere else and it's false by default so most likely this checkbox is not used anymore and can be removed.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Group issues Project issues
group_issues_bulk_edit project_issues_bulk_edit

How to set up and validate locally

Case 1

  1. Open some group.
  2. Goto group Issues
  3. Click Bulk edit
  4. Edit Labels

Case 2

  1. Open some project.
  2. Goto project Issues
  3. Click Bulk edit
  4. Edit Labels

Related to #446219 (closed)

Edited by Taras Tadai

Merge request reports