Skip to content

Move cron management to remove_sidekiq_jobs method

James Nutt requested to merge jn/update-remove-sidekiq-jobs into master

What does this MR do and why?

Move cron management to remove_sidekiq_jobs method

As per #442475, this MR moves management of the cron schedule to the sidekiq_remove_jobs method and updates the sidekiq compatibility guidelines.

This should result in functionally similar behaviour, but:

  • It ensures we remove job schedules before scheduled instances.
  • It's easier for engineers to take advantage of.

The downside is that we lose flexibility around removing a job vs. disabling it but if we've removed the job from the configuration, it seems more likely that we would want to remove the schedule than turn it off.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports