Skip to content

Downgrade lefthook to 1.3.13

Peter Leitzen requested to merge pl-lefthook into master

What does this MR do and why?

This should resolve some "error getting file: exit 128" failures.

See https://github.com/evilmartians/lefthook/issues/612

For example:

 [lefthook] cmd: [git branch  --remotes]
 [lefthook] dir: /home/peter/devel/gitlab/gdk/gitlab
 [lefthook] err: exit status 128
 [lefthook] out: fatal: ' --remotes' is not a valid branch name

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Pushing to gitlab.com:gitlab-org/gitlab
╭────────────────────────────────────╮
│ 🥊 lefthook v1.6.5  hook: pre-push │
╰────────────────────────────────────╯
│  merge_conflicts (skip) settings
┃  security_harness ❯


│  static-verification (skip) settings
│  db-schema-changes (skip) no files for inspection
│  haml-lint (skip) no files for inspection
│  stylelint (skip) no files for inspection
│  vale (skip) no files for inspection
│  yamllint (skip) no files for inspection
│  docs-metadata (skip) no files for inspection
│  audit_event_types_docs (skip) no files for inspection
│  bundler-checksum-lint (skip) no matching push files
│  eslint (skip) no files for inspection
│  verify-tff-mapping (skip) no files for inspection
│  rubocop (skip) no files for inspection
│  jsonlint (skip) no files for inspection
│  db-migration-name-collisions (skip) no files for inspection
│  sidekiq-queues (skip) no files for inspection
│  mermaidlint (skip) no files for inspection
│  prettier (skip) no files for inspection
│  docs-deprecations (skip) no files for inspection
│  graphql_docs (skip) no files for inspection
│  markdownlint (skip) no files for inspection
│  custom_roles_docs (skip) no files for inspection
│  gettext (skip) no files for inspection
┃  danger ❯

Results:

Messages:
- [ ] **[CHANGELOG missing](https://docs.gitlab.com/ee/development/changelog.html)**:

If this merge request [doesn't need a CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry), feel free to ignore this message.

Markdown:

## Rubygems

This merge request adds, or changes a Rubygems dependency. Please review the [Gemfile guidelines](https://docs.gitlab.com/ee/development/gemfile.html).


  ────────────────────────────────────
summary: (done in 9.85 seconds)
✔️  security_harness
✔️  danger

How to set up and validate locally

bundle exec lefthook version
bundle exec lefthook run -v pre-push
bundle exec lefthook run -v pre-commit
Edited by Peter Leitzen

Merge request reports