Project last commit info inconsistent height fix
requested to merge 432924-project-last-commit-info-w-code-owners-has-inconsistent-height-when-loading into master
What does this MR do and why?
Adding minimum height and some padding to make sure the spinner occupies the same vertical space as a component that replaces it. Added padding also brings the spinner into the middle of its container. It was glued to the top boarder.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
Screen recording of a last commit info loading before fixing | Screen recording of a last commit info loading after fixing |
How to set up and validate locally
- Open a project
- You may use Throttling in the Network tab in your browser to easier see the change on loading
- Click on the selected file from repository
- Observe the spinner position and layout while the page is loading
Numbered steps to set up and validate the change are strongly suggested.
Related to #432924 (closed)
Edited by Paulina Sedlak-Jakubowska