Skip to content
Snippets Groups Projects

Add tracking for issues_mrs_empty_state experiment

All threads resolved!

What does this MR do and why?

Add tracking for issues_mrs_empty_state experiment

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

!147661 (merged)

How to set up and validate locally

bin/rails c

Feature.enable(:issues_mrs_empty_state)

For the MRs empty state:

sequence activity category action label
(Control/Candidate) User renders MR empty state page - question are we able to tell from where? ex. Nav, Learn GitLab, etc. projects:merge_requests:index render_project_mrs_empty_list_page project_mrs_empty_list
(Candidate) User clicks play on Merge Request video - - -
(Control/Candidate) User clicks New Merge Request or Create a new merge request button projects:merge_requests:index click_new_mr_project_mrs_empty_list_page new_mr_project_mrs_empty_list
(Candidate) User clicks Learn more about merge requests button projects:merge_requests:index click_learn_more_project_mrs_empty_list_page learn_more_project_mrs_empty_list

For the Issues empty state:

sequence activity category action label
(Control/Candidate) User renders Issues empty state page - question are we able to tell from where? ex. Nav, Learn GitLab, etc. projects:issues:index render_project_issues_empty_list_page project_issues_empty_list
(Candidate) User clicks play on Issue video - - -
(Control/Candidate) User clicks on Learn more about issues projects:issues:index click_learn_more_project_issues_empty_list_page learn_more_project_issues_empty_list
(Control/Candidate) User clicks New Issue or Create new issue button projects:issues:index click_new_issue_project_issues_empty_list_page new_issue_project_issues_empty_list
(Control/Candidate) User clicks on Email a new issue to this project or Email a new issue projects:issues:index click_email_issue_project_issues_empty_list_page email_issue_project_issues_empty_list
(Control/Candidate) User clicks on Import projects:issues:index click_import_csv_project_issues_empty_list_page / click_import_jira_project_issues_empty_list_page CSV or JIRA
(Control/Candidate) User clicks on JIRA integration projects:issues:index click_jira_int_project_issues_empty_list_page jira_int_project_issues_empty_list

Related to #436480 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 4 Warnings
    :warning: f3de1ce0: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    :warning: 7f064388: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    :warning:

    featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

    For more information, see:

    :warning: This merge request contains lines with testid selectors. Please ensure e2e:package-and-test job is run.
    2 Messages
    :book: This merge request includes changes to Vue files that have both CE and EE versions.
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Vue <template> in CE and EE

    Some Vue files in CE have a counterpart in EE. (For example, path/to/file.vue and ee/path/to/file.vue.)

    When run in the context of CE, the <template> of the CE Vue file is used. When run in the context of EE, the <template> of the EE Vue file is used.

    It's easy to accidentally make a change to a CE <template> that should appear in both CE and EE without making the change in both places. When this happens, the change only takes effect in CE.

    The following Vue files were changed as part of this merge request that include both a CE and EE version of the file:

    • app/assets/javascripts/issues/list/components/issues_list_app.vue

    If you made a change to the <template> of any of these Vue files that should be visible in both CE and EE, please ensure you have made your change to both versions of the file.

    A better alternative

    An even better alternative is to refactor this component to only use a single template for both CE and EE. More info on this approach here: https://docs.gitlab.com/ee/development/ee_features.html#template-tag

    testid selectors

    The following changed lines in this MR contain testid selectors:

    ee/app/views/shared/empty_states/_merge_requests_without_filters.html.haml

    +            data: { testid: 'new-merge-request-button',

    app/assets/javascripts/issues/list/components/empty_state_without_any_issues.vue

    +    data-testid="signed-in-empty-state-block"

    app/assets/javascripts/issues/list/components/empty_state_without_any_issues_experiment.vue

    +          data-testid="empty-state-learn-more-link"
    +          data-testid="empty-state-jira-int-link"

    app/views/shared/empty_states/_merge_requests_without_filters.html.haml

    -          data: { testid: 'new-merge-request-button', event_tracking: 'click_new_merge_request_empty_list' }
    +          data: { testid: 'new-merge-request-button', **project_tracking_data }

    If the e2e:package-and-test job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the manual:e2e-test-pipeline-generate job in the prepare stage and ensure the tests in follow-up:e2e:package-and-test-ee pipeline are passing.

    For the list of known failures please refer to the latest pipeline triage issue.

    If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

    Reviewer roulette

    Category Reviewer Maintainer
    backend @rkumar555 profile link current availability (UTC+5.5, 2.5 hours ahead of author) @Andyschoenen profile link current availability (UTC+2, 1 hour behind author)
    frontend @apennells profile link current availability (UTC-4, 7 hours behind author) @fguibert profile link current availability (UTC+10, 7 hours ahead of author)
    QA @jay_mccure profile link current availability (UTC+10, 7 hours ahead of author) Maintainer review is optional for QA

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits e35bc7b1 and f3de1ce0

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.26 MB 4.26 MB - 0.0 %
    mainChunk 3.23 MB 3.23 MB - 0.0 %

    Note: We do not have exact data for e35bc7b1. So we have used data from: 5d532659.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-package-and-test: :x: test report for f3de1ce0

    expand test summary
    +---------------------------------------------------------------------+
    |                           suites summary                            |
    +----------------+--------+--------+---------+-------+-------+--------+
    |                | passed | failed | skipped | flaky | total | result |
    +----------------+--------+--------+---------+-------+-------+--------+
    | Create         | 529    | 9      | 81      | 10    | 619   | ❌     |
    | Systems        | 10     | 0      | 0       | 0     | 10    | ✅     |
    | Manage         | 38     | 0      | 12      | 1     | 50    | ✅     |
    | Govern         | 254    | 1      | 19      | 0     | 274   | ❌     |
    | Verify         | 139    | 0      | 23      | 0     | 162   | ✅     |
    | Package        | 197    | 0      | 37      | 0     | 234   | ✅     |
    | GitLab Metrics | 2      | 0      | 1       | 0     | 3     | ✅     |
    | Plan           | 226    | 3      | 17      | 0     | 246   | ❌     |
    | Fulfillment    | 6      | 0      | 64      | 1     | 70    | ✅     |
    | Data Stores    | 111    | 0      | 26      | 0     | 137   | ✅     |
    | Monitor        | 33     | 0      | 12      | 0     | 45    | ✅     |
    | Analytics      | 6      | 0      | 0       | 0     | 6     | ✅     |
    | Configure      | 1      | 0      | 7       | 0     | 8     | ✅     |
    | Growth         | 0      | 0      | 4       | 0     | 4     | ➖     |
    | ModelOps       | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Secure         | 6      | 0      | 3       | 0     | 9     | ✅     |
    | Ai-powered     | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Release        | 10     | 0      | 3       | 0     | 13    | ✅     |
    +----------------+--------+--------+---------+-------+-------+--------+
    | Total          | 1568   | 13     | 315     | 12    | 1896  | ❌     |
    +----------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-gdk: :white_check_mark: test report for f3de1ce0

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Govern      | 66     | 0      | 0       | 0     | 66    | ✅     |
    | Plan        | 51     | 0      | 2       | 0     | 53    | ✅     |
    | Monitor     | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Create      | 77     | 0      | 9       | 0     | 86    | ✅     |
    | Verify      | 35     | 0      | 1       | 0     | 36    | ✅     |
    | Data Stores | 31     | 0      | 0       | 0     | 31    | ✅     |
    | Package     | 24     | 0      | 6       | 0     | 30    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 298    | 0      | 19      | 0     | 317   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for f3de1ce0

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 123    | 0      | 16      | 2     | 139   | ✅     |
    | Govern      | 78     | 0      | 6       | 1     | 84    | ✅     |
    | Package     | 26     | 0      | 10      | 0     | 36    | ✅     |
    | Plan        | 74     | 0      | 4       | 0     | 78    | ✅     |
    | Data Stores | 31     | 0      | 7       | 0     | 38    | ✅     |
    | Verify      | 43     | 0      | 9       | 0     | 52    | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Monitor     | 12     | 0      | 4       | 0     | 16    | ✅     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Fulfillment | 2      | 0      | 23      | 0     | 25    | ✅     |
    | Manage      | 2      | 0      | 2       | 0     | 4     | ✅     |
    | Release     | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Secure      | 2      | 0      | 1       | 0     | 3     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Ai-powered  | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 399    | 0      | 89      | 3     | 488   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • added 1042 commits

    • df5348f9...7cd0869f - 1041 commits from branch 436480-empty-state-experiment
    • 0ed37d44 - Add tracking for issues_mrs_empty_state experiment

    Compare with previous version

  • Serhii Yarynovskyi Parental Leave from 2025-02-21 to 2025-06-09 changed title from Draft: Implement issues_mrs_empty_state experiment to Draft: Add tracking for issues_mrs_empty_state experiment

    changed title from Draft: Implement issues_mrs_empty_state experiment to Draft: Add tracking for issues_mrs_empty_state experiment

  • changed milestone to %16.11

  • Serhii Yarynovskyi Parental Leave from 2025-02-21 to 2025-06-09 deleted the 436480-empty-state-experiment branch. This merge request now targets the master branch

    deleted the 436480-empty-state-experiment branch. This merge request now targets the master branch

  • A deleted user added QA label

    added QA label

  • Serhii Yarynovskyi Parental Leave from 2025-02-21 to 2025-06-09 changed the description

    changed the description

  • Serhii Yarynovskyi Parental Leave from 2025-02-21 to 2025-06-09 changed the description

    changed the description

  • Serhii Yarynovskyi Parental Leave from 2025-02-21 to 2025-06-09 changed the description

    changed the description

  • Serhii Yarynovskyi Parental Leave from 2025-02-21 to 2025-06-09 changed the description

    changed the description

  • Serhii Yarynovskyi Parental Leave from 2025-02-21 to 2025-06-09 changed the description

    changed the description

  • Serhii Yarynovskyi Parental Leave from 2025-02-21 to 2025-06-09 changed the description

    changed the description

  • Serhii Yarynovskyi Parental Leave from 2025-02-21 to 2025-06-09 changed the description

    changed the description

  • added 2466 commits

    • 0ed37d44...ae9c001e - 2463 commits from branch master
    • 266f51fb - Implement issues_mrs_empty_state experiment for MRs
    • 0251d8e5 - Remove video from groups empty list
    • 40791dce - Add tracking for issues_mrs_empty_state experiment

    Compare with previous version

  • Serhii Yarynovskyi Parental Leave from 2025-02-21 to 2025-06-09 changed target branch from master to 436480-empty-state-experiment-mrs-list

    changed target branch from master to 436480-empty-state-experiment-mrs-list

  • Serhii Yarynovskyi Parental Leave from 2025-02-21 to 2025-06-09 changed the description

    changed the description

  • added 1 commit

    • d674df91 - Add tracking for issues_mrs_empty_state experiment

    Compare with previous version

  • Serhii Yarynovskyi Parental Leave from 2025-02-21 to 2025-06-09 changed the description

    changed the description

  • Serhii Yarynovskyi Parental Leave from 2025-02-21 to 2025-06-09 deleted the 436480-empty-state-experiment-mrs-list branch. This merge request now targets the master branch

    deleted the 436480-empty-state-experiment-mrs-list branch. This merge request now targets the master branch

  • :tools: Generated by gitlab_quality-test_tooling.


    :snail: Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

    Click to expand
    Job File Name Duration Expected duration
    #6540250853 spec/features/issues/csv_spec.rb#L32 Issues csv triggers an email export 63.7 s < 50.13 s
    #6540250853 spec/features/issues/csv_spec.rb#L38 Issues csv doesn't send request params to ExportCsvWorker 63.58 s < 50.13 s
    #6540250853 spec/features/issues/csv_spec.rb#L44 Issues csv displays flash message 63.84 s < 50.13 s
    #6540250853 spec/features/issues/csv_spec.rb#L51 Issues csv includes a csv attachment 63.98 s < 50.13 s
    #6540250853 spec/features/issues/csv_spec.rb#L57 Issues csv ignores pagination 67.12 s < 50.13 s
    #6540250853 spec/features/issues/csv_spec.rb#L65 Issues csv uses filters from issue index 63.89 s < 50.13 s
    #6540250853 spec/features/issues/csv_spec.rb#L71 Issues csv ignores sorting from issue index 64.59 s < 50.13 s
    #6540250853 spec/features/issues/csv_spec.rb#L80 Issues csv uses array filters, such as label_name 63.86 s < 50.13 s
    #6540250853 spec/features/reportable_note/issue_spec.rb#L17 Reportable note on issue behaves like reportable note report button links to a report page 65.44 s < 50.13 s
  • A deleted user added rspec:slow test detected label
  • added 1248 commits

    Compare with previous version

  • marked this merge request as ready

  • Marcos Rocha approved this merge request

    approved this merge request

  • Marcos Rocha requested review from @acook.gitlab and removed review request for @mc_rocha

    requested review from @acook.gitlab and removed review request for @mc_rocha

  • Allen Cook approved this merge request

    approved this merge request

  • Allen Cook removed review request for @acook.gitlab

    removed review request for @acook.gitlab

  • Minahil Nichols approved this merge request

    approved this merge request

  • Minahil Nichols requested review from @fguibert and removed review request for @minahilnichols

    requested review from @fguibert and removed review request for @minahilnichols

  • added 374 commits

    Compare with previous version

  • reset approvals from @acook.gitlab by pushing to the branch

  • Florie Guibert approved this merge request

    approved this merge request

  • Florie Guibert resolved all threads

    resolved all threads

  • Florie Guibert enabled an automatic merge when the pipeline for 91d3e645 succeeds

    enabled an automatic merge when the pipeline for 91d3e645 succeeds

  • Serhii Yarynovskyi Parental Leave from 2025-02-21 to 2025-06-09 aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • added 335 commits

    Compare with previous version

  • @fguibert I rebased MR to fix the tests. Could you pls set to merge again? Thanks

  • @fguibert, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:

    1. Ensure the merge request is not in Draft status.
    2. Start a pipeline (especially important for Community contribution merge requests).
    3. Set the merge request to auto-merge.

    This is a guideline, not a rule. Please consider replying to this comment for transparency.

    This message was generated automatically. You're welcome to improve it.

  • mentioned in commit d0a14202

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading