Allow Adding Members Already in Group When Using Block Seat Overages
What does this MR do and why?
If a member is already in a group, and the member is added to that group again, then the add is successful and the member's role is updated if changed by the new add request.
This behavior should be preserved for the case when block seat overages is enabled and all the seats in the group are taken.
Prior to this MR, the request would be rejected with an error message that all the seats are full.
This entire feature is currently behind a feature flag.
Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/443383
Overarching issue describing the feature: https://gitlab.com/gitlab-org/gitlab/-/issues/432733
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screen recordings
The behavior seen in the After video is also what we find when block seat overages is not enabled, or when it is enabled but the seats are not yet all taken.
| Before | After |
|---|---|
| Screen_Recording_2024-03-02_at_7.19.28_PM | Screen_Recording_2024-03-02_at_7.22.34_PM |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.