Resolve flaky test in user_approves_with_password_spec.rb

What does this MR do?

The reason we're getting a StaleElementReferenceError is because the .js-mr-approvals-modal is already removed from the DOM after clicking "Cancel".

Also, I think the intent here is to check that no "Approved by" is found on the page and not inside the modal.

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation created/updated or follow-up review issue created
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Performance and testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

Closes #12767 (closed)