Skip to content

Downcase deployment name in Google Cloud runner provisioning

Pedro Pombeiro (OOO from July 16th till Aug 7th) requested to merge pedropombeiro/438316/downcase-deployment-name into master

What does this MR do and why?

While testing the scripts for runner deployment in Google Cloud, I found an error due to the fact that we use the deployment name to create resources such as VPCs. These don't allow uppercase characters, so this MR downcases the deployment name in Google Cloud runner provisioning. The reason we don't do this in the Terraform script itself is:

  1. It would require a lot of changes to the GRIT templates to ensure that any string can be massaged into the required format, not just for VPCs either
  2. The deployment name that gets registered would no longer match the resource names that you then see in the Google Cloud console

EE: true

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

n/a

Edited by Pedro Pombeiro (OOO from July 16th till Aug 7th)

Merge request reports