Skip to content

Rename actual_head_pipeline to diff_head_pipeline

Hordur Freyr Yngvason requested to merge rename-actual-head-pipeline-to-diff-head-pipeline into master

What does this MR do and why?

Rename actual_head_pipeline to diff_head_pipeline

The "actual" in these method names was a misnomer. These methods all retrieved the pipeline by MergeRequest#diff_head_sha, which is not updated at the same time as the repository. This is an important distinction, because branch pipeline can be created for a merge request's source branch before the merge request diff has been updated.

The updated name is more descriptive and makes it easier to spot possible race conditions caused by lagging merge request diffs.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Hordur Freyr Yngvason

Merge request reports