Update reviewer status icons to outlined from solid
What does this MR do and why?
Update reviewer status icons in merge request sidebar
Why?
- Icons should be outlined by default unless there's a specific, necessary use case (https://design.gitlab.com/product-foundations/iconography#fills)
- Mentioned in #417911 (comment 1795996933)
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Go to merge request, review MR with three states (approve, request changes, comment)
Links
Merge request reports
Activity
changed milestone to %16.10
added UX UX Paper Cuts frontend maintenanceusability typemaintenance labels
assigned to @annabeldunstone
Reviewer roulette
Category Reviewer Maintainer frontend @robyrne
(UTC+0, same timezone as author)
@ankit.panchal
(UTC+5.5, 5.5 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Jacques Erasmus
@mnearents The comment icon is looking a bit cramped now
Were we planning to create astatus-comment
icon for this purpose?/cc @jeldergl
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits fc7e22ba and de50202e
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.23 MB 4.23 MB - -0.0 % mainChunk 3.22 MB 3.22 MB - 0.0 %
Note: We do not have exact data for fc7e22ba. So we have used data from: b8c8aa64.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerOpened this as discussed on Slack; happy to close it if we'd prefer to keep the current size
requested review from @mnearents and @jeldergl
requested review from @afracazo and removed review request for @mnearents
added pipeline:mr-approved label
- Resolved by Jacques Erasmus
@jeldergl
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for de50202eexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Create | 66 | 0 | 9 | 0 | 75 | ✅ | | Package | 24 | 0 | 2 | 0 | 26 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 287 | 0 | 15 | 0 | 302 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for de50202eexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Create | 8 | 0 | 3 | 4 | 11 | ✅ | | Data Stores | 2 | 0 | 0 | 2 | 2 | ✅ | | Plan | 3 | 0 | 1 | 2 | 4 | ✅ | | Monitor | 4 | 0 | 0 | 4 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 5 | 12 | 25 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
requested review from @mnearents
removed review request for @mnearents
removed review request for @jeldergl
requested review from @rhardarson
requested review from @jerasmus
enabled an automatic merge when the pipeline for 0bfbb438 succeeds
@jerasmus, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit 40fe881f
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#5518 (closed)
mentioned in merge request kubitus-project/kubitus-installer!2869 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label