Skip to content

Resolve "Improve default title and description of issues opened from managed Prometheus alerts"

What does this MR do?

This MR improve the default title and description of incident issues by

  • parsing mandatory labels/alertname as title
  • parsing and exposing alerts' mandatory start time (via starts_at)
  • parsing and exposing alerts' full query (via generatorURL)

Despite these improvements this MR also

  • moves alert summary creation logic into the alert presenter
  • refactors several speccs
  • uses rfc3339 consistently

Please see individual commit messages to watch tiny, incremental steps.

Refs #11212 (closed)

Screenshots

Minimal alert with only labels/alertname Screenshot_from_2019-07-10_18-25-58
Average alert Screenshot_from_2019-07-10_18-24-50
GitLab-managed alert Screenshot_from_2019-07-12_16-48-01

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports