Skip to content

Fix activity links for milestones with duplicate names

Brett Walker requested to merge 424736-milestones-with-duplicate-name-at-different-group-levels-cause-activity-links-to-break into master

What does this MR do and why?

If there happen to be multiple group milestones with the same name, the system note generated when assigning the milestones to an issue always links the same milestone.

NOTE: This MR requires Allow milestone references to specify a full path (!143859 - merged) to be merged first. That MR has been cherry-picked here as the first commit in order to develop this.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  • create a top-level group names "Engineering". Inside it create a milestone called "Milestone A"
  • inside the "Engineering" group, create a group called "Mobile". Inside it create a milestone called "Milestone A" (yes, same as the one in "Engineering")
  • inside the "Mobile" group, create a project called "iOS". Create a new issue in the project
  • in a comment add /milestone /engineering/mobile%"Milestone A" and save
  • roll your mouse over the link in the system note, and it should be linking to the correct milestone
  • in a comment add /milestone /engineering%"Milestone A" and save
  • roll your mouse over the link in the system note, and it should be linking to the correct milestone

Related to #424736 (closed)

Edited by Brett Walker

Merge request reports