Query deploy keys by matching title

changed milestone to %16.10

added Category:Source Code Management Deliverable backend devopscreate featureaddition frontend-weight2 groupsource code sectiondev typefeature workflowin dev labels

assigned to @j.seto

added database databasereview pending labels

3 Warnings

: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines.

: The commit subject and body must be separated by a blank line. For more information, take a look at our Commit message guidelines.

featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

For more information, see:

The Handbook page on merge request types.
The definition of done documentation.

1 Message

CHANGELOG missing:

If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Category	Reviewer	Maintainer
backend	`@partiaga` (UTC+11, 11 hours ahead of author)	`@marc_shaw` (UTC+9, 9 hours ahead of author)
database	`@johnmason` (UTC-5, 5 hours behind author)	`@pshutsin` (UTC+1, 1 hour ahead of author)

Please check reviewer's status!

Reviewer is available!
Reviewer is unavailable!

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

marked this merge request as ready

changed the description

hi @qzhaogitlab could you please do the initial review for backend?

requested review from @qzhaogitlab

hi @morefice could you please do the initial review for database ?

requested review from @morefice

approved this merge request

added pipeline:mr-approved label

@qzhaogitlab, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break master, a new pipeline will be started shortly.

Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.

requested review from @minac and removed review request for @qzhaogitlab

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 21efb0b1

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Govern      | 3      | 0      | 0       | 0     | 3     | ✅     |
| Create      | 66     | 0      | 9       | 0     | 75    | ✅     |
| Monitor     | 4      | 0      | 0       | 0     | 4     | ✅     |
| Plan        | 4      | 0      | 0       | 0     | 4     | ✅     |
| Package     | 0      | 0      | 1       | 0     | 1     | ➖     |
| Data Stores | 2      | 0      | 0       | 0     | 2     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 79     | 0      | 10      | 0     | 89    | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for 21efb0b1

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 566    | 0      | 58      | 10    | 624   | ✅     |
| Package     | 0      | 0      | 2       | 0     | 2     | ➖     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Plan        | 8      | 0      | 0       | 0     | 8     | ✅     |
| Data Stores | 4      | 0      | 0       | 0     | 4     | ✅     |
| Govern      | 6      | 0      | 0       | 0     | 6     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 592    | 0      | 60      | 10    | 652   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

approved this merge request

added databasereviewed label and removed databasereview pending label

removed review request for @morefice

requested review from @a_akgun

removed review request for @minac

added 2 commits

9c943e46 - Refactor to use scopes on DeployKey
21efb0b1 - - Fix incorrect test

Compare with previous version

requested review from @minac

approved this merge request

removed review request for @minac

approved this merge request

added databaseapproved label and removed databasereviewed label

removed review request for @a_akgun

resolved all threads

requested review from @a_akgun

enabled an automatic merge when the pipeline for 31a6b536 succeeds

merged

Hello @j.seto

The database team is looking for ways to improve the database review process and we would love your help!

If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning: