Skip to content

Fix webhooks API push_event_branch_filter / branch_filter_strategy

clxrx requested to merge gitlab-community/gitlab:cler_x/438490-fix-push_event_branch_filter into master

What does this MR do and why?

Should fix this issue #438490 (closed)

  • param branch_filter_strategy was missing from project, group and system hooks. This made it fall back to its default value wildcard
  • I added the param to the api then exposed it on the entity.
  • I added tests for POST/PUT

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports