Removes the `have_locked_schema` tests from vulnerability specs
What does this MR do and why?
Removes the it { is_expected.to have_locked_schema ...
test from the vulnerabilities/finding_spec
and the vulnerability_spec
related to: #349315 (closed)
In a slack thread (internal only) we discussed the possibility of removing these checks.
The summary of where that thread went is:
The schema lock was also introduced to remind the authors of the changes that adding a new column to vulnerabilities and vulnerability_occurrences table can probably require replicating that column in vulnerability_reads if we want to filter/sort by that new column. Given we all know the use of vulnerability_reads , I think we can remove that schema lock implementation entirely without any replacement
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.