Skip to content

Don't force when generating background migration in housekeeper

Dylan Griffith requested to merge housekeeper-finalize-bbm-no-force into master

What does this MR do and why?

This force: true option seems to generate the migration even if there is an existing migration with the exact same name. Additionally it deletes the existing migration with the same name. This is probably not something we ever intended to do so I'm removing it.

At some point we may want to update this to skip finalizing a BBM if a migration with a matching name exists (or generate a guaranteed unique name) but it's not clear to me if we actually have a use case for this now. Also there are plans to be more strict about not re-using batched background migrations so possibly the matching name won't be very common in future.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports