Use sentence case for DORA metrics titles
What does this MR do and why?
Use sentence case for DORA metrics titles:
-
Deployment Frequency
→Deployment frequency
-
Lead Time for Changes
→Lead time for changes
-
Time to Restore Service
→Time to restore service
-
Change Failure Rate
→Change failure rate
-
Critical Vulnerabilities over time
→Critical vulnerabilities over time
-
High Vulnerabilities over time
→High vulnerabilities over time
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
(Note: these screenshots are from GDK with fake data)
How to set up and validate locally
- Check out this branch locally
- Visit a Value Streams Dashboard for a group in your gdk (
http://gdk.test:3000/groups/$GROUP/-/analytics/dashboards/value_streams_dashboard
) - You will see that the titles in the
Metric
column are now in sentence case. - Click through to "Deployment frequency". You will see that all instances of "Deployment frequency" are in sentence case.
- Click through to "Lead time for changes". You will see that all instances of "Lead time for changes" are in sentence case.
- Click through to "Time to restore service". You will see that all instances of "Time to restore service" are in sentence case.
- Click through to "Change failure rate". You will see that all instances of "Change failure rate" are in sentence case.
Related to #442145 (closed) and #424397 (closed)
Merge request reports
Activity
changed milestone to %16.10
assigned to @clavimoniere
removed workflowin dev label
removed Technical Writing label
2 Warnings c209cc88: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. c209cc88: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Reviewer roulette
Category Reviewer Maintainer backend @hmerscher
(UTC+1, 6 hours ahead of author)
@mfangitlab
(UTC-8, 3 hours behind author)
frontend @kpalchyk
(UTC+2, 7 hours ahead of author)
@iamphill
(UTC+0, 5 hours ahead of author)
test for spec/features/*
@hmerscher
(UTC+1, 6 hours ahead of author)
Maintainer review is optional for test for spec/features/*
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 8e012988 and c209cc88
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.21 MB 4.21 MB - 0.0 % mainChunk 3.21 MB 3.21 MB - 0.0 %
Note: We do not have exact data for 8e012988. So we have used data from: 757f5dfb.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Chad Lavimoniere
I'm trying to make sure I get reviews on my stuff from Plan folks now. @cablett could you do a BE review here?
requested review from @cablett
- Resolved by charlie ablett
Looks like there is a merge conflict @clavimoniere - would you please have a look?
Otherwise LGTM
added pipeline:mr-approved label
- Resolved by Chad Lavimoniere
@cablett
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for c209cc88expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 53 | 0 | 0 | 0 | 53 | ✅ | | Create | 8 | 0 | 3 | 0 | 11 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 70 | 0 | 4 | 0 | 74 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for c209cc88expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 255 | 0 | 13 | 0 | 268 | ✅ | | Create | 153 | 0 | 19 | 4 | 172 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 426 | 0 | 34 | 4 | 460 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
added 442 commits
-
c057a518...fd0b07cf - 441 commits from branch
master
- c209cc88 - Merge remote-tracking branch 'origin/master' into 442145-vsd-metrics-table-should-use-sentence-case
-
c057a518...fd0b07cf - 441 commits from branch
reset approvals from @cablett by pushing to the branch
- Resolved by Chad Lavimoniere
@ekigbo I'm trying to make sure I get reviews on my stuff from Plan folks now. Could you do a FE review of this?
requested review from @ekigbo