Resolve Issue list page size control overlap
What does this MR do and why?
Apply new util classes to make issueables list pagination behave in desired manner. See related issue Issue list page size control overlaps paginatio... (#389569 - closed).
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Viewport width | Before | After |
---|---|---|
1000px (lg) | ![]() |
![]() |
790px (md) | ![]() |
![]() |
700px (sm) | ![]() |
![]() |
400px (xs) | ![]() |
![]() |
How to set up and validate locally
- Check out this branch locally
- Navigate to http://gdk.test:3000/groups/gitlab-org/-/issues
- Resize the window so that it is smaller than our
md
breakpoint - You will see that the pagination now behaves the same as the pagination at the bottom of https://gitlab.com/gitlab-org/gitlab/-/security/vulnerability_report in small viewports
Related to #389569 (closed), #425467 (closed)
Merge request reports
Activity
changed milestone to %16.10
added Category:Team Planning SLOMissed UX Paper Cuts bugux devopsplan groupproject management sectiondev severity4 typebug vintage + 1 deleted label
assigned to @clavimoniere
- A deleted user
added frontend label
2 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/issuable/list/components/issuable_list_root.vue
Reviewer roulette
Category Reviewer Maintainer frontend @marina.mosti
(UTC+1, 6 hours ahead of author)
@jerasmus
(UTC+1, 6 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 57cf438d and 2308ffc9
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.23 MB 4.23 MB -2.78 KB -0.1 % mainChunk 3.22 MB 3.22 MB - 0.0 % New entry points: 3Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.groups.analytics.cycle_analytics.show 0 Bytes 4.99 MB +4.99 MB 100.0 % pages.groups.analytics.cycle_analytics.value_streams.edit 0 Bytes 335.25 KB +335.25 KB 100.0 % pages.groups.analytics.cycle_analytics.value_streams.new 0 Bytes 335.25 KB +335.25 KB 100.0 %
Note: We do not have exact data for 57cf438d. So we have used data from: efd0339b.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 1 commit
- 7cf54ef1 - Update tailwind class name for md:gl-absolute
changed milestone to %16.11
added 1467 commits
-
7cf54ef1...1939a619 - 1465 commits from branch
master
- 04b39c7c - WIP - OVERWRITE COMMIT LATER
- 881f0cf6 - Update tailwind class name for md:gl-absolute
-
7cf54ef1...1939a619 - 1465 commits from branch
added 1 commit
- a2669ebb - Resolve Issue list page size control overlap
added 25 commits
-
a2669ebb...e3912bbf - 24 commits from branch
master
- 2308ffc9 - Resolve Issue list page size control overlap
-
a2669ebb...e3912bbf - 24 commits from branch
requested review from @rcrespo3
Nice work @clavimoniere, LGTM
removed review request for @rcrespo3
added pipeline:mr-approved label
- Resolved by Justin Ho Tuan Duong
@rcrespo3
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 2308ffc9expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Create | 8 | 0 | 3 | 0 | 11 | ✅ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 68 | 0 | 6 | 0 | 74 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 2308ffc9expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 8 | 0 | 3 | 2 | 11 | ✅ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Plan | 3 | 0 | 1 | 2 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 5 | 4 | 25 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 2308ffc9expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 249 | 0 | 19 | 0 | 268 | ✅ | | Create | 153 | 0 | 20 | 0 | 173 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 420 | 0 | 41 | 0 | 461 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
mentioned in issue gitlab-com/www-gitlab-com#34689 (closed)
requested review from @justin_ho
- Resolved by Chad Lavimoniere
enabled an automatic merge when the pipeline for 89ebc74b succeeds
mentioned in commit b72e882f
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#5534 (closed)
mentioned in commit 17e7820d
mentioned in commit e583dbd1
mentioned in merge request kubitus-project/kubitus-installer!2869 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label