Skip to content
Snippets Groups Projects

Resolve Issue list page size control overlap

All threads resolved!

What does this MR do and why?

Apply new util classes to make issueables list pagination behave in desired manner. See related issue Issue list page size control overlaps paginatio... (#389569 - closed).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Viewport width Before After
1000px (lg) gdk.test_3000_groups_gitlab-org_-issues__9 gdk.test_3000_groups_gitlab-org_-issues__8
790px (md) gdk.test_3000_groups_gitlab-org_-_issues gdk.test_3000_groups_gitlab-org_-issues__3
700px (sm) gdk.test_3000_groups_gitlab-org_-issues__1 gdk.test_3000_groups_gitlab-org_-issues__4
400px (xs) gdk.test_3000_groups_gitlab-org_-issues__2 gdk.test_3000_groups_gitlab-org_-issues__6

How to set up and validate locally

  1. Check out this branch locally
  2. Navigate to http://gdk.test:3000/groups/gitlab-org/-/issues
  3. Resize the window so that it is smaller than our md breakpoint
  4. You will see that the pagination now behaves the same as the pagination at the bottom of https://gitlab.com/gitlab-org/gitlab/-/security/vulnerability_report in small viewports

Related to #389569 (closed), #425467 (closed)

Edited by Chad Lavimoniere

Merge request reports

Merged results pipeline #1207552825 passed

Pipeline: Ruby 3.1 as-if-foss pipeline

#1207553595

    Pipeline: GitLab

    #1207555243

      Pipeline: E2E GDK

      #1207555419

        +3

        Merged results pipeline passed for 89ebc74b

        Test coverage 70.02% (5.15%) from 2 jobs

        Merged by Justin Ho Tuan DuongJustin Ho Tuan Duong 11 months ago (Mar 10, 2024 1:04am UTC)

        Loading

        Pipeline #1207747217 failed

        Pipeline: [click_house-client gem] Ruby 3.0 pipeline

        #1207747266

          Pipeline: [gitlab-rspec_flaky gem] Ruby 3.0 pipeline

          #1207747264

            Pipeline: [devise-pbkdf2-encryptable gem] Ruby 3.0 pipeline

            #1207747300

              +29

              Pipeline failed for b72e882f on master

              Test coverage 73.06% (5.15%) from 2 jobs
              5 environments impacted.

              Activity

              Filter activity
              • Approvals
              • Assignees & reviewers
              • Comments (from bots)
              • Comments (from users)
              • Commits & branches
              • Edits
              • Labels
              • Lock status
              • Mentions
              • Merge request status
              • Tracking
            • Justin Ho Tuan Duong approved this merge request

              approved this merge request

            • Have 1 non-blocking question which can be added later on. Setting MWPS to get this merged before Summit.

            • Justin Ho Tuan Duong resolved all threads

              resolved all threads

            • Justin Ho Tuan Duong enabled an automatic merge when the pipeline for 89ebc74b succeeds

              enabled an automatic merge when the pipeline for 89ebc74b succeeds

            • mentioned in commit b72e882f

            • mentioned in commit 17e7820d

            • mentioned in commit e583dbd1

            • Chad Lavimoniere changed the description

              changed the description

            • Please register or sign in to reply
              Loading