Skip to content

Refactor loading of vulnerability feedback

Heinrich Lee Yu requested to merge refactor-vulnerability-feedback into master

What does this MR do?

Refactors extracting of ids from an array of hashes. This makes the intent clearer and I think saves some memory as well.

Also changes find_each to each since we don't really save any memory with find_each because we collect the models returned to BatchLoader

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Coung Ngo

Merge request reports