Skip to content

Memoize API::Search search_service

Ivan Sebastian requested to merge ivantedja/gitlab:memoize-api-search-service into master

What does this MR do and why?

This MR accommodates issue #378180 (closed)

Multiple call on search_service in API::Search cause multiple time instantiation on SearchService.

This MR memoize the call using strong memoization as suggested in here

I'm not too sure how to do the e2e test, so I was only validating it via the unit test

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Run the rspec from terminal:

$ bin/rspec spec/requests/api/search_spec.rb:774

Merge request reports