Skip to content

Remove most components used within legacy finding modal

Lorenz van Herwaarden requested to merge remove-finding-modal-iteration-3 into master

What does this MR do and why?

Related #441279 (closed)

This is part of the removal of the legacy finding modal which isn't used anywhere anymore.

In an earlier removal iteration (!145568 (merged)) the ModalFooter and DismissButton were removed.

This MR in turn removes:

  1. dismissal_comment_box.vue (and spec)
  2. dismissal_comment_box_toggle.vue (and spec)
  3. dismissal_comment_modal_footer.vue (and spec)
  4. issue_note.vue (and spec)
  5. solution_card_vuex.vue (and spec)
  6. translations

and updates modal.vue template such that these components are removed.

The whole spec of the modal (modal_spec.js) is also removed.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Lorenz van Herwaarden

Merge request reports