Feat: profile edit main settings part one

Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.

When you're ready for a first review, post @gitlab-bot ready. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with @gitlab-bot ready @user1 @user2.

At any time, if you need help, feel free to post @gitlab-bot help or initiate a mentor session on Discord. Read more on how to get help.

You can comment @gitlab-bot label <label1> <label2> to add labels to your MR. Please see the list of allowed labels in the label command documentation.

This message was generated automatically. You're welcome to improve it.

added Community contribution workflowin dev labels

assigned to @JeremyWuuuuu

@gitlab-bot ready @peterhegman

Hi @peterhegman, as suggested I splitted the MR to 2 parts, and this one is the first one. This MR is still looking large because of the main functionality about this Main Settings section is the email part, while we update the email, we are required to input our password to the backend for confirmation. But for each file we have at most ~100 lines change. I think this would be much easier for reviewers to do the review. Please let me know if you have any questions

added workflowready for review label and removed workflowin dev label

requested review from @peterhegman

@peterhegman, this Community contribution is ready for review.

Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.

This message was generated automatically. You're welcome to improve it.

@gitlab-bot help

Hey there @xanf, could you please help @JeremyWuuuuu out?

This message was generated automatically. You're welcome to improve it.

requested review from @xanf

Hello @xanf, would you mind reviewing this MR for me? Since @peterhegman is on vacation.

	5 Warnings
	This merge request is quite big (759 lines changed), please consider splitting it into multiple merge requests.
	d8005b68: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
	This merge request does not refer to an existing milestone.
	This merge request contains lines with testid selectors. Please ensure `e2e:package-and-test` job is run.
	Labels missing: please ask a reviewer or maintainer to add frontend, backend to this merge request.

1 Message

CHANGELOG missing:

If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

`testid` selectors

The following changed lines in this MR contain testid selectors:

`app/assets/javascripts/profile/edit/components/main_settings.vue`

+        data-testid="profile-edit-name"
+        data-testid="profile-edit-id"
+        data-testid="profile-edit-pronouns"
+        data-testid="profile-edit-pronunciation"
+        data-testid="profile-edit-email"

`app/assets/javascripts/profile/edit/components/profile_edit_app.vue`

+      data-testid="profile-main-settings"
+        data-testid="submit-edit-button"

If the e2e:package-and-test job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the trigger-omnibus-and-follow-up-e2e job in the qa stage and ensure the tests in follow-up-e2e:package-and-test-ee pipeline are passing.

For the list of known failures please refer to the latest pipeline triage issue.

If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

Reviewer roulette

Category	Reviewer	Maintainer
backend	`@serenafang` (UTC-6)	`@michold` (UTC+1)
frontend	`@minahilnichols` (UTC-5)	`@psjakubowska` (UTC+1)
test for `spec/features/*`	`@serenafang` (UTC-6)	Maintainer review is optional for test for `spec/features/*`

Please check reviewer's status!

Reviewer is available!
Reviewer is unavailable!

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 1 commit

ee46fa89 - Feat: profile edit main settings part one

Compare with previous version

added 1 commit

97bfd724 - Feat: profile edit main settings part one

Compare with previous version

added 1 commit

d2649ed9 - Feat: profile edit main settings part one

Compare with previous version

added 1 commit

d8005b68 - Feat: profile edit main settings part one

Compare with previous version

mentioned in issue gitlab-org/quality/triage-reports#16451 (closed)

added grouptenant scale label

added devopsdata stores sectioncore platform labels

added typefeature label

removed review request for @peterhegman

@xanf, this Community contribution was recently assigned to you for review.

Do you still have capacity to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
Add the workflowin dev label if the merge request needs action from the author.

This message was generated automatically. You're welcome to improve it.

added automation:reviewers-reminded label

added idle label

mentioned in issue gitlab-org/quality/triage-reports#17340 (closed)

removed idle label

added 12162 commits

d8005b68...b41b1983 - 12161 commits from branch gitlab-org:master
62202aac - Feat: profile edit main settings part one

Compare with previous version

added pipelinetier-1 label

mentioned in issue #389918

	3 Warnings
	This merge request is quite big (835 lines changed), please consider splitting it into multiple merge requests.
	16f7c83e: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
	This merge request contains lines with testid selectors. Please ensure `e2e:package-and-test` job is run.

1 Message

CHANGELOG missing:

If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

`testid` selectors

The following changed lines in this MR contain testid selectors:

`app/assets/javascripts/profile/edit/components/main_settings.vue`

+        data-testid="profile-edit-name"
+        data-testid="profile-edit-id"
+        data-testid="profile-edit-pronouns"
+        data-testid="profile-edit-pronunciation"
+        data-testid="profile-edit-email"

`app/assets/javascripts/profile/edit/components/profile_edit_app.vue`

+        data-testid="submit-edit-button"

If the e2e:package-and-test job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the manual:e2e-test-pipeline-generate job in the prepare stage and ensure the tests in follow-up:e2e:package-and-test-ee pipeline are passing.

For the list of known failures please refer to the latest pipeline triage issue.

If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

Reviewer roulette

Category	Reviewer	Maintainer
backend	`@mkhalifa3` (UTC+2)	`@mfangitlab` (UTC-7)
frontend	`@jrushford` (UTC+2)	`@pgascouvaillancourt` (UTC-4)
test for `spec/features/*`	`@mkhalifa3` (UTC+2)	Maintainer review is optional for test for `spec/features/*`
UX	`@mnichols1` (UTC-4)	Maintainer review is optional for UX

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

mentioned in merge request !143932 (closed)

changed milestone to %17.1

added backend frontend labels

requested review from @joseph and @dzubova and removed review request for @xanf

requested review from @greg

added UX label

Thanks for helping us improve the UX of GitLab. Your contribution is appreciated! We have pinged our UX team, so stay tuned for their feedback.

This message was generated automatically. You're welcome to improve it.

requested changes

removed review request for @dzubova

Hi @JeremyWuuuuu, backend is looking mostly OK, but could you please rebase the branch so that it is up to date?

Hi @dzubova, I have addressed most of your comments, would you mind review this once again? I have a question for a comment you left, thank you!

added 2441 commits

62202aac...a0d5bf7e - 2439 commits from branch gitlab-org:master
c1101fd9 - Feat: profile edit main settings part one
0b296d07 - Address MR comments

Compare with previous version

requested review from @dzubova

issue: the e-mail link is not shown correctly

before	after

issue: I see a couple of improvements for the flow here:

Screen_Recording_2024-05-28_at_19.15.26

I expect the modal window to close no matter if the password was valid or not. It's worth to check with the UX here though. cc @pedroms as you were chosen by roulette
I expect that the form would save the fields that need a password confirmation (in our case meow5 in Pronunciation field. On reload this field sets to a previous value.

requested changes

added 215 commits

0b296d07...19d7ba12 - 212 commits from branch gitlab-org:master
363854ac - Feat: profile edit main settings part one
cd4c5a89 - Address MR comments
9df32408 - Address MR comments

Compare with previous version

Hi @dzubova, I have updated the code as suggested, but for the testing one I would like it to remain the same because I think if we separate the test it would look redundant. I also left one question for you, Thank you in advance for your patience.

requested review from @dzubova

added linked-issue label

changed the description

requested review from @pedroms

approved this merge request

requested review from @peterhegman and removed review request for @dzubova

added pipeline:mr-approved label

@dzubova, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break master, please start a new pipeline before merging.

Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.

added pipelinetier-2 label and removed pipelinetier-1 label

@dzubova, thanks for approving this merge request.

This is the first time the merge request has been approved. Please wait for AppSec approval before merging.

cc @gitlab-com/gl-security/appsec this is a JiHu contribution, please follow the JiHu contribution review process.

requested review from @ealcantara and removed review request for @peterhegman

approved this merge request

added sec-planningcomplete label

approved this merge request

No concerns from an AppSec perspective.

approved this merge request

requested review from @georgekoltsov and removed review request for @joseph

removed review request for @georgekoltsov

approved this merge request

added pipelinetier-3 label and removed pipelinetier-2 label

	3 Warnings
	This merge request is quite big (835 lines changed), please consider splitting it into multiple merge requests.
	16f7c83e: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
	This merge request contains lines with testid selectors. Please ensure `e2e:package-and-test` job is run.

1 Message

CHANGELOG missing:

If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

`testid` selectors

The following changed lines in this MR contain testid selectors:

`app/assets/javascripts/profile/edit/components/main_settings.vue`

+        data-testid="profile-edit-name"
+        data-testid="profile-edit-id"
+        data-testid="profile-edit-pronouns"
+        data-testid="profile-edit-pronunciation"
+        data-testid="profile-edit-email"

`app/assets/javascripts/profile/edit/components/profile_edit_app.vue`

+        data-testid="submit-edit-button"

If the e2e:package-and-test job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the manual:e2e-test-pipeline-generate job in the prepare stage and ensure the tests in follow-up:e2e:package-and-test-ee pipeline are passing.

For the list of known failures please refer to the latest pipeline triage issue.

If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

Reviewer roulette

Category	Reviewer	Maintainer
backend	`@hmerscher` (UTC+2)	`@reprazent` (UTC+2)
frontend	`@eduardobonet` (UTC+2)	`@afontaine` (UTC-4)
test for `spec/features/*`	`@hmerscher` (UTC+2)	Maintainer review is optional for test for `spec/features/*`
UX	`@mnichols1` (UTC-4)	Maintainer review is optional for UX

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits ffd62ef0 and 346e4257

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.29 MB	4.29 MB	-	0.0 %
mainChunk	3.25 MB	3.25 MB	-	0.0 %

Note: We do not have exact data for ffd62ef0. So we have used data from: 999e33d1.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for bed17622

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Verify      | 43     | 0      | 3       | 0     | 46    | ✅     |
| Create      | 126    | 0      | 12      | 0     | 138   | ✅     |
| Plan        | 60     | 0      | 2       | 0     | 62    | ✅     |
| Package     | 19     | 0      | 12      | 0     | 31    | ✅     |
| Govern      | 65     | 0      | 0       | 0     | 65    | ✅     |
| Data Stores | 27     | 0      | 4       | 0     | 31    | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
| Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
| Fulfillment | 1      | 0      | 0       | 0     | 1     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 356    | 0      | 34      | 0     | 390   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for 346e4257

expand test summary

+---------------------------------------------------------------------+
|                           suites summary                            |
+----------------+--------+--------+---------+-------+-------+--------+
|                | passed | failed | skipped | flaky | total | result |
+----------------+--------+--------+---------+-------+-------+--------+
| Create         | 425    | 0      | 48      | 9     | 473   | ✅     |
| Package        | 31     | 0      | 14      | 0     | 45    | ✅     |
| Systems        | 7      | 0      | 0       | 0     | 7     | ✅     |
| Plan           | 88     | 0      | 11      | 0     | 99    | ✅     |
| Govern         | 109    | 0      | 8       | 1     | 117   | ✅     |
| Monitor        | 12     | 0      | 13      | 0     | 25    | ✅     |
| Manage         | 30     | 0      | 15      | 1     | 45    | ✅     |
| GitLab Metrics | 2      | 0      | 1       | 0     | 3     | ✅     |
| Verify         | 52     | 0      | 14      | 0     | 66    | ✅     |
| Fulfillment    | 4      | 0      | 24      | 0     | 28    | ✅     |
| Configure      | 1      | 0      | 3       | 0     | 4     | ✅     |
| Analytics      | 3      | 0      | 0       | 0     | 3     | ✅     |
| Data Stores    | 43     | 0      | 14      | 0     | 57    | ✅     |
| Ai-powered     | 0      | 0      | 2       | 0     | 2     | ➖     |
| Growth         | 0      | 0      | 2       | 0     | 2     | ➖     |
| Release        | 5      | 0      | 1       | 0     | 6     | ✅     |
| Secure         | 3      | 0      | 2       | 0     | 5     | ✅     |
| ModelOps       | 0      | 0      | 1       | 0     | 1     | ➖     |
+----------------+--------+--------+---------+-------+-------+--------+
| Total          | 815    | 0      | 173     | 11    | 988   | ✅     |
+----------------+--------+--------+---------+-------+-------+--------+

e2e-test-on-cng: test report for bed17622

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
| Create      | 138    | 0      | 16      | 0     | 154   | ✅     |
| Plan        | 83     | 0      | 11      | 0     | 94    | ✅     |
| Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
| Manage      | 2      | 0      | 8       | 0     | 10    | ✅     |
| Ai-powered  | 0      | 0      | 1       | 0     | 1     | ➖     |
| Govern      | 79     | 0      | 9       | 0     | 88    | ✅     |
| Verify      | 52     | 0      | 14      | 0     | 66    | ✅     |
| Data Stores | 30     | 0      | 13      | 0     | 43    | ✅     |
| Package     | 22     | 1      | 15      | 0     | 38    | ❌     |
| ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
| Secure      | 3      | 0      | 2       | 0     | 5     | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Fulfillment | 2      | 0      | 24      | 0     | 26    | ✅     |
| Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
| Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 426    | 1      | 132     | 0     | 559   | ❌     |
+-------------+--------+--------+---------+-------+-------+--------+

@JeremyWuuuuu Impressive work . I left a few minor requests .

requested changes

@ealcantara I have addressed all the comments you left, would you mind take a look on this once again? Thank you in advance.

requested review from @ealcantara

added 3105 commits

9df32408...1efbdeb9 - 3101 commits from branch gitlab-org:master
292f7689 - Feat: profile edit main settings part one
b9ca3b35 - Address MR comments
fd1bf6bf - Address MR comments
7707fe6e - Address MR comments

Compare with previous version

added sec-planningpending-followup label and removed sec-planningcomplete label

reset approvals from @georgekoltsov by pushing to the branch

unapproved this merge request

approved this merge request

added pipelinetier-2 label and removed pipelinetier-3 label

added sec-planningcomplete label and removed sec-planningpending-followup label

added 1 commit

e99060ad - Fix test issue

Compare with previous version

added sec-planningpending-followup label and removed sec-planningcomplete label

added 1 commit

4629dc35 - Fix left out test

Compare with previous version

approved this merge request

added pipelinetier-3 label and removed pipelinetier-2 label

unapproved this merge request

approved this merge request

added sec-planningcomplete label and removed sec-planningpending-followup label

resolved all threads

enabled automatic add to merge train when the pipeline for 6e7705b8 succeeds

@JeremyWuuuuu The FOSS_ONLY pipeline also failed and it looks related to this change https://gitlab.com/gitlab-org/gitlab-foss/-/jobs/7123942510. I wish I could provide more context, but I don't have time to investigate. Could you take a look, please?

Assign back to me once the pipeline is green.

removed review request for @ealcantara

added typemaintenance label and removed typefeature label

unapproved this merge request

approved this merge request

resolved all threads

changed milestone to %17.2

added 983 commits

4629dc35...52e69191 - 976 commits from branch gitlab-org:master
dd7c6be0 - Feat: profile edit main settings part one
10294896 - Address MR comments
e6e41242 - Address MR comments
68b218e1 - Address MR comments
9c8a0df1 - Fix test issue
c58da1b1 - Fix left out test
af08a8ae - Fix testing issue

Compare with previous version

added sec-planningpending-followup label and removed sec-planningcomplete label

reset approvals from @ealcantara by pushing to the branch

added 1 commit

ac55dafe - Fix testing issue

Compare with previous version

requested review from @JeremyWuuuuu and @ealcantara

removed review request for @JeremyWuuuuu

unapproved this merge request

approved this merge request

added pipelinetier-2 label and removed pipelinetier-3 label

added sec-planningcomplete label and removed sec-planningpending-followup label

removed review request for @ealcantara

added 656 commits

ac55dafe...649e1cf5 - 648 commits from branch gitlab-org:master
fb41bcc5 - Feat: profile edit main settings part one
b20ab8f3 - Address MR comments
69c44daa - Address MR comments
c472b667 - Address MR comments
10da8395 - Fix test issue
2ed1231b - Fix left out test
4aad84bd - Fix testing issue
b5eaa64a - Fix all testing issue

Compare with previous version

added sec-planningpending-followup label and removed sec-planningcomplete label

requested review from @ealcantara

Generated by gitlab_quality-test_tooling.

Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

Click to expand

Job	File	Name	Duration	Expected duration
#7179398483	`spec/lib/search/settings_spec.rb#L6`	Search results for settings behaves like all sections exist and have correct anchor links has only valid settings sections	31.88 s	< 27.12 s
#7263305199	`spec/lib/search/settings_spec.rb#L6`	Search results for settings behaves like all sections exist and have correct anchor links has only valid settings sections	30.9 s	< 27.12 s
#7263305381	`ee/spec/lib/ee/search/settings_spec.rb#L19`	Search results for settings behaves like all sections exist and have correct anchor links has only valid settings sections	47.87 s	< 27.12 s
#7286084714	`spec/lib/search/settings_spec.rb#L6`	Search results for settings behaves like all sections exist and have correct anchor links has only valid settings sections	42.83 s	< 27.12 s
#7286084990	`ee/spec/lib/ee/search/settings_spec.rb#L19`	Search results for settings behaves like all sections exist and have correct anchor links has only valid settings sections	47.56 s	< 27.12 s

added rspec:slow test detected label

approved this merge request

added pipelinetier-3 label and removed pipelinetier-2 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3.

Before you resolve this discussion, please check the following:

You are the last maintainer of this merge request
The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please resolve this discussion and the set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

unapproved this merge request

approved this merge request

added sec-planningcomplete label and removed sec-planningpending-followup label

approved this merge request

Hi @ealcantara , it looks like there was a undercoverage error reported, for the failure 1st and 3rd I can add more tests, but for the 2nd one, I think there was already test cases included, could you help me here for what I should to in order to get this MR pipeline passed?

added 1590 commits

b5eaa64a...8ae7a0f1 - 1581 commits from branch gitlab-org:master
16f7c83e - Feat: profile edit main settings part one
e51d3548 - Address MR comments
d313a9f6 - Address MR comments
90f64e89 - Address MR comments
28b7a1d9 - Fix test issue
0c3bf011 - Fix left out test
5b93ea05 - Fix testing issue
f9acbd56 - Fix all testing issue
346e4257 - Restore removed test

Compare with previous version

added sec-planningpending-followup label and removed sec-planningcomplete label

reset approvals from @ealcantara by pushing to the branch

unapproved this merge request

approved this merge request

added sec-planningcomplete label and removed sec-planningpending-followup label

resolved all threads

approved this merge request

enabled automatic add to merge train when the pipeline for fcac1500 succeeds

Hi @ealcantara, looks like the job start-as-if-foss failed again

@JeremyWuuuuu , The test that you reintroduced in !145629 (346e4257) is failing. Follow the instructions in !145629 (346e4257, comment 1964237407) to run this test in your local environment. You have to fix the failure, but we shouldn't remove the test because it will cause the undercoverage failure in !145629 (346e4257, comment 1969827723)

HI @ealcantara, I think I have resolved the test issue, I tried to run the rspec locally w/ and w/o the environment variable FOSS_ONLY=1, both passed locally, but the undercoverage has appeared again, and I am pretty sure that those reported undercoverage code is 100% covered, would you mind help me out on this please? So sorry for bothering you again

@JeremyWuuuuu I'm happy to help you, and you are not bothering at all. I'm having a hard time figuring out why this is happening. I will request help from a backend engineer to identify where the lack of coverage is.

@joseph @georgekoltsov Could you help us identify what the rspec undercoverage job indicates that some of the view helpers implemented in this MR lack test coverage ?

Hi @ealcantara Did you get any update on the failures above? I see that the two people you mentioned are either blocked or on PTO, so could it be the case to try and bring in someone else to try and get this over the line?

@zillemarco No, I didn't. Let's try pinging another backend reviewer. I relaunched the danger roulette, and I got two new recommendations.

@serenafang Could you review the backend changes in this Merge Request, and help @JeremyWuuuuu identify why the undercoverage job fails ?

@serenafang will you have time to review this change?

I took a look at the undercoverage error, could it be because the methods are tested like this:

allow(user).to receive(:read_only_attribute?).with(:name).and_return(true)

so the method's return value is stubbed rather than the method actually being called?

@JeremyWuuuuu Could you try using .and_call_original rather than .and_return and see if the undercoverage job passes?

added 1 commit

bed17622 - Fix the testing issue

Compare with previous version

added sec-planningpending-followup label and removed sec-planningcomplete label

reset approvals from @ealcantara by pushing to the branch

unapproved this merge request

approved this merge request

added sec-planningcomplete label and removed sec-planningpending-followup label

removed review request for @ealcantara

changed milestone to %17.3

added idle label

Security policy violations have been resolved.

mentioned in issue gitlab-org/quality/triage-reports#19195 (closed)

changed milestone to %17.4

mentioned in issue gitlab-org/quality/triage-reports#19280 (closed)

mentioned in issue gitlab-org/quality/triage-reports#19365 (closed)

mentioned in issue gitlab-org/quality/triage-reports#19535 (closed)

mentioned in issue gitlab-org/quality/triage-reports#19650 (closed)

mentioned in issue gitlab-org/quality/triage-reports#19662 (closed)

mentioned in issue gitlab-org/quality/triage-reports#19799 (closed)

mentioned in issue gitlab-org/quality/triage-reports#19909 (closed)

removed idle label

requested review from @serenafang

added idle label

mentioned in issue gitlab-org/quality/triage-reports#20322 (closed)

mentioned in issue gitlab-org/quality/triage-reports#20438 (closed)

mentioned in issue gitlab-org/quality/triage-reports#20575 (closed)

mentioned in issue gitlab-org/quality/triage-reports#20743 (closed)

added groupglobal search label and removed grouptenant scale label

mentioned in issue gitlab-org/quality/triage-reports#20823 (closed)

added devopsfoundations label and removed devopsdata stores label

mentioned in issue gitlab-org/quality/triage-reports#20942 (closed)

mentioned in issue gitlab-org/quality/triage-reports#21132 (closed)

mentioned in issue gitlab-org/quality/triage-reports#21253 (closed)

added grouporganizations label and removed groupglobal search label

mentioned in issue gitlab-org/developer-relations/contributor-success/team-task#713 (closed)

mentioned in issue gitlab-org/quality/triage-reports#21704 (closed)

mentioned in issue gitlab-org/quality/triage-reports#21743 (closed)

mentioned in issue gitlab-org/quality/triage-reports#21746 (closed)

removed idle label

Hi @JeremyWuuuuu are you still interested in working on this?

added idle label

mentioned in issue gitlab-org/quality/triage-reports#22183 (closed)

mentioned in issue gitlab-org/quality/triage-reports#22191 (closed)

mentioned in issue gitlab-org/quality/triage-reports#22193 (closed)

mentioned in issue gitlab-org/quality/triage-reports#22194 (closed)

mentioned in issue gitlab-org/quality/triage-reports#22195 (closed)

mentioned in issue gitlab-org/quality/triage-reports#22291 (closed)

added workflowin dev label and removed workflowready for review label

removed automation:reviewers-reminded label

@JeremyWuuuuu, it seems we're waiting on an action from you for approximately two weeks.

Do you still have capacity to work on this? If not, you might want to close this MR and/or ask someone to take over.
Do you need help in getting it ready? At any time, you can:
- ask for help with @gitlab-bot help.
- initiate a mentor session on Discord.
If you're actually ready for a review, you can post @gitlab-bot ready.

This message was generated automatically. You're welcome to improve it.

added automation:author-reminded label

Feat: profile edit main settings part one

What does this MR do and why?

MR acceptance checklist

Screenshots or screen recordings

Before submitting

Submitting with email changed

How to set up and validate locally

Activity

`testid` selectors

`app/assets/javascripts/profile/edit/components/main_settings.vue`

`app/assets/javascripts/profile/edit/components/profile_edit_app.vue`

Reviewer roulette

`testid` selectors

`app/assets/javascripts/profile/edit/components/main_settings.vue`

`app/assets/javascripts/profile/edit/components/profile_edit_app.vue`

Reviewer roulette

`testid` selectors

`app/assets/javascripts/profile/edit/components/main_settings.vue`

`app/assets/javascripts/profile/edit/components/profile_edit_app.vue`

Reviewer roulette

Bundle size analysis [beta]

Special assets

E2E Test Result Summary

Before you set this MR to auto-merge

Feat: profile edit main settings part one

What does this MR do and why?

MR acceptance checklist

Screenshots or screen recordings

Before submitting

Submitting with email changed

How to set up and validate locally

Merge request reports

Activity

testid selectors

app/assets/javascripts/profile/edit/components/main_settings.vue

app/assets/javascripts/profile/edit/components/profile_edit_app.vue

Reviewer roulette

testid selectors

app/assets/javascripts/profile/edit/components/main_settings.vue

app/assets/javascripts/profile/edit/components/profile_edit_app.vue

Reviewer roulette

testid selectors

app/assets/javascripts/profile/edit/components/main_settings.vue

app/assets/javascripts/profile/edit/components/profile_edit_app.vue

Reviewer roulette

Bundle size analysis [beta]

Special assets

E2E Test Result Summary

Before you set this MR to auto-merge

`testid` selectors

`app/assets/javascripts/profile/edit/components/main_settings.vue`

`app/assets/javascripts/profile/edit/components/profile_edit_app.vue`

`testid` selectors

`app/assets/javascripts/profile/edit/components/main_settings.vue`

`app/assets/javascripts/profile/edit/components/profile_edit_app.vue`

`testid` selectors

`app/assets/javascripts/profile/edit/components/main_settings.vue`

`app/assets/javascripts/profile/edit/components/profile_edit_app.vue`