Skip to content

Geo: Fix incorrect return values and a flaky test

Michael Kozono requested to merge mk/geo-fix-flaky-test-and-incorrect-return-values into master

What does this MR do and why?

  • Fixes incorrect return values. When the check fails, it should return falsey, not a string.
  • Fixes a flaky test (it was making an actual NTP request).

Resolves gitlab-org/quality/engineering-productivity/master-broken-incidents#5349 (closed)

Resolves #442813 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Michael Kozono

Merge request reports