Skip to content

Fix link anchors for synthetic system notes

Heinrich Lee Yu requested to merge fix-system-note-link-anchors into master

What does this MR do and why?

System notes from label, milestone, and state changes are represented by synthetic system notes that have an alphanumeric ID. We should not call getIdFromGraphQLId on these because these would return null.

This is a regression from 3255cf6d

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before:

Screenshot_2024-02-22_at_5.08.24_PM

After:

Screenshot_2024-02-22_at_5.08.58_PM

How to set up and validate locally

  1. Change some labels on an issue
  2. Hover over the timestamp link and check the anchor
  3. You can also click on the timestamp and it should get highlighted and the browser URL updated to the correct link with anchor
Edited by Heinrich Lee Yu

Merge request reports